Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Rename form template parent class

Browse Source 
[MAILPOET-2810]
This commit is contained in:
Rostislav Wolny
2020-08-05 16:32:43 +02:00
committed by Veljko V
parent 7087bd3b3c
commit 79c70c8341
6 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Form/Templates/Template.php → lib/Form/Templates/FormTemplate.php
View File

@@ -4,7 +4,7 @@ namespace MailPoet\Form\Templates;
use MailPoet\Entities\FormEntity;
abstract class Template {
abstract class FormTemplate {
abstract public function getName(): string;
abstract public function getBody(): array;

6
lib/Form/Templates/TemplateRepository.php
View File

@@ -17,19 +17,19 @@ class TemplateRepository {
'demo_form' => DemoForm::class,
];
public function getFormTemplate(string $templateId): Template {
public function getFormTemplate(string $templateId): FormTemplate {
if (!isset($this->templates[$templateId])) {
throw UnexpectedValueException::create()
->withErrors(["Template with id $templateId doesn't exist."]);
}
/** @var Template $template */
/** @var FormTemplate $template */
$template = new $this->templates[$templateId]();
return $template;
}
/**
* @param string[] $templateIds
* @return Template[] associative array with template ids as keys
* @return FormTemplate[] associative array with template ids as keys
*/
public function getFormTemplates(array $templateIds): array {
$result = [];

4
lib/Form/Templates/Templates/DefaultForm.php
View File

@@ -2,12 +2,12 @@
namespace MailPoet\Form\Templates\Templates;
use MailPoet\Form\Templates\Template;
use MailPoet\Form\Templates\FormTemplate;
/**
* Template for default form created on plugin activation
*/
class DefaultForm extends Template {
class DefaultForm extends FormTemplate {
public function getName(): string {
return _x('My First Form', 'default name of form (GDPR friendly) to capture emails', 'mailpoet');
}

4
lib/Form/Templates/Templates/DemoForm.php
View File

@@ -2,12 +2,12 @@
namespace MailPoet\Form\Templates\Templates;
use MailPoet\Form\Templates\Template;
use MailPoet\Form\Templates\FormTemplate;
/**
* Temporary form template. Remove after we get real data from designer
*/
class DemoForm extends Template {
class DemoForm extends FormTemplate {
public function getName(): string {
return 'My Fancy Form';
}

4
lib/Form/Templates/Templates/InitialForm.php
View File

@@ -2,9 +2,9 @@
namespace MailPoet\Form\Templates\Templates;
use MailPoet\Form\Templates\Template;
use MailPoet\Form\Templates\FormTemplate;
class InitialForm extends Template {
class InitialForm extends FormTemplate {
public function getName(): string {
return '';
}

4
tests/unit/Form/Templates/TemplatesRepositoryTest.php
View File

@@ -2,7 +2,7 @@
namespace MailPoet\Test\Form\Templates;
use MailPoet\Form\Templates\Template;
use MailPoet\Form\Templates\FormTemplate;
use MailPoet\Form\Templates\TemplateRepository;
class TemplatesRepositoryTest extends \MailPoetUnitTest {
@@ -16,7 +16,7 @@ class TemplatesRepositoryTest extends \MailPoetUnitTest {
public function testItCanBuildFormTemplate() {
$formEntity = $this->repository->getFormTemplate(TemplateRepository::INITIAL_FORM_TEMPLATE);
expect($formEntity)->isInstanceOf(Template::class);
expect($formEntity)->isInstanceOf(FormTemplate::class);
expect($formEntity->getStyles())->notEmpty();
expect($formEntity->getBody())->notEmpty();
expect($formEntity->getSettings())->notEmpty();