Remove premium-specific ES config, move free-specific rules to its config

[MAILPOET-5015]

mailpoet/eslint.config.js

@@ -26,4 +26,27 @@ module.exports = [
     ...config,
     files: ['tests/javascript_newsletter_editor/**/*.js'],
   })),
+
+  // ES6 config overrides
+  {
+    files: ['assets/js/src/**/*.jsx', 'tests/javascript/**/*.js'],
+    rules: {
+      'no-script-url': 0,
+      'react/destructuring-assignment': 0, // that would be too many changes to fix this one
+      'prefer-destructuring': 0, // that would be too many changes to fix this one
+      'jsx-a11y/label-has-for': [
+        2,
+        {
+          required: { some: ['nesting', 'id'] }, // some of our labels are hidden and we cannot nest those
+        },
+      ],
+      'jsx-a11y/anchor-is-valid': 0, // cannot fix this one, it would break wordpress themes
+      'jsx-a11y/label-has-associated-control': [
+        2,
+        {
+          either: 'either', // control has to be either nested or associated via htmlFor
+        },
+      ],
+    },
+  },
 ];

packages/js/eslint-config/eslint-es6.config.js

@@ -41,26 +41,10 @@ module.exports = [
       'react-hooks/exhaustive-deps': 'warn',
       // Exceptions
       'no-only-tests/no-only-tests': 2,
-      'no-script-url': 0,
       'class-methods-use-this': 0,
       'react/jsx-props-no-spreading': 0,
       'import/extensions': 0, // we wouldn't be able to import jQuery without this line
       'import/prefer-default-export': 0, // we want to stop using default exports and start using named exports
-      'react/destructuring-assignment': 0, // that would be too many changes to fix this one
-      'prefer-destructuring': 0, // that would be too many changes to fix this one
-      'jsx-a11y/label-has-for': [
-        2,
-        {
-          required: { some: ['nesting', 'id'] }, // some of our labels are hidden and we cannot nest those
-        },
-      ],
-      'jsx-a11y/anchor-is-valid': 0, // cannot fix this one, it would break wprdpress themes
-      'jsx-a11y/label-has-associated-control': [
-        2,
-        {
-          either: 'either', // control has to be either nested or associated via htmlFor
-        },
-      ],
       'import/no-default-export': 1, // no default exports
     },
   },

packages/js/eslint-config/eslint-premium.config.js

@@ -1,47 +0,0 @@
-const babelParser = require('@babel/eslint-parser');
-const FlatCompat = require('@eslint/eslintrc').FlatCompat;
-const airbnbConfig = require('eslint-config-airbnb');
-const prettierConfig = require('eslint-config-prettier');
-const webpackResolver = require('eslint-import-resolver-webpack');
-const reactJsxRuntimeConfig = require('eslint-plugin-react/configs/jsx-runtime');
-const reactHooksPlugin = require('eslint-plugin-react-hooks');
-const globals = require('globals');
-
-// compat configs
-const compat = new FlatCompat({ baseDirectory: __dirname });
-const airbnbCompatConfig = compat.config(airbnbConfig);
-const prettierCompatConfig = compat.config(prettierConfig);
-
-// React plugin is already defined by airbnb config. This fixes:
-//   TypeError: Key "plugins": Cannot redefine plugin "react"
-delete reactJsxRuntimeConfig.plugins.react;
-
-module.exports = [
-  ...airbnbCompatConfig,
-  reactJsxRuntimeConfig,
-  ...prettierCompatConfig,
-  {
-    languageOptions: {
-      parser: babelParser,
-      globals: {
-        ...globals.browser,
-      },
-    },
-    settings: {
-      'import/resolver': { webpack: webpackResolver },
-    },
-    plugins: {
-      'react-hooks': reactHooksPlugin,
-    },
-    rules: {
-      'class-methods-use-this': 0,
-      // React hooks rules
-      'react-hooks/rules-of-hooks': 'error',
-      'react-hooks/exhaustive-deps': 'warn',
-      'import/prefer-default-export': 0, // we want to stop using default exports and start using named exports
-      // Exceptions
-      'import/extensions': 0, // we wouldn't be able to import jQuery without this line
-      'import/no-default-export': 1, // no default exports
-    },
-  },
-];