Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Use enum instead of hardcoded string

Browse Source 
[MAILPOET-3227]
This commit is contained in:
Jan Lysý
2021-04-22 17:27:17 +02:00
committed by Veljko V
parent 7694db2c2a
commit 7e2a5c9935
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
assets/js/src/segments/dynamic/dynamic_segments_filters/woocommerce.tsx
View File

@@ -36,16 +36,21 @@ export function validateWooCommerce(formItems: WooCommerceFormItem): boolean {
) {
return false;
}
if (formItems.action === 'purchasedCategory' && !formItems.category_id) {
if (formItems.action === WooCommerceActionTypes.PURCHASED_CATEGORY && !formItems.category_id) {
return false;
}
if (formItems.action === 'purchasedProduct' && !formItems.product_id) {
if (formItems.action === WooCommerceActionTypes.PURCHASED_PRODUCT && !formItems.product_id) {
return false;
}
if (formItems.action === 'numberOfOrders' && (!formItems.number_of_orders_count || !formItems.number_of_orders_days || !formItems.number_of_orders_type)) {
const numberOfOrdersIsInvalid = !formItems.number_of_orders_count
|| !formItems.number_of_orders_days
|| !formItems.number_of_orders_type;
if (formItems.action === WooCommerceActionTypes.NUMBER_OF_ORDERS && numberOfOrdersIsInvalid) {
return false;
}
if (formItems.action === 'totalSpent' && (!formItems.total_spent_amount || !formItems.total_spent_days || !formItems.total_spent_type)) {
if (formItems.action === WooCommerceActionTypes.TOTAL_SPENT
&& (!formItems.total_spent_amount || !formItems.total_spent_days || !formItems.total_spent_type)
) {
return false;
}
return true;