Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Make NewsletterTemplateEntity name mandatory

Browse Source 
[MAILPOET-2647]
This commit is contained in:
Jan Jakeš
2020-03-16 16:51:47 +01:00
committed by Veljko V
parent a0ee6dadba
commit 7e60e9ba7e
4 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/Entities/NewsletterTemplateEntity.php
View File

@ -57,6 +57,10 @@ class NewsletterTemplateEntity {
*/ */
private $readonly = false; private $readonly = false;
public function __construct(string $name) {
$this->name = $name;
}
/** /**
* @return NewsletterEntity|null * @return NewsletterEntity|null
*/ */

2
lib/NewsletterTemplates/NewsletterTemplatesRepository.php
View File

@ -42,7 +42,7 @@ class NewsletterTemplatesRepository extends Repository {
: null; : null;
if (!$template) { if (!$template) {
$template = new NewsletterTemplateEntity(); $template = new NewsletterTemplateEntity($data['name'] ?? '');
$this->entityManager->persist($template); $this->entityManager->persist($template);
} }

6
tests/integration/API/JSON/v1/NewsletterTemplatesTest.php
View File

@ -18,13 +18,11 @@ class NewsletterTemplatesTest extends \MailPoetTest {
$this->truncateEntity(NewsletterTemplateEntity::class); $this->truncateEntity(NewsletterTemplateEntity::class);
$this->newsletterTemplatesRepository = $this->diContainer->get(NewsletterTemplatesRepository::class); $this->newsletterTemplatesRepository = $this->diContainer->get(NewsletterTemplatesRepository::class);
$template1 = new NewsletterTemplateEntity(); $template1 = new NewsletterTemplateEntity('Template #1');
$template1->setName('Template #1');
$template1->setBody(['key1' => 'value1']); $template1->setBody(['key1' => 'value1']);
$this->entityManager->persist($template1); $this->entityManager->persist($template1);
$template2 = new NewsletterTemplateEntity(); $template2 = new NewsletterTemplateEntity('Template #2');
$template2->setName('Template #2');
$template2->setBody(['key2' => 'value2']); $template2->setBody(['key2' => 'value2']);
$template2->setNewsletter($this->entityManager->getReference(NewsletterEntity::class, 1)); $template2->setNewsletter($this->entityManager->getReference(NewsletterEntity::class, 1));
$this->entityManager->persist($template2); $this->entityManager->persist($template2);

3
tests/integration/NewsletterTemplates/NewsletterTemplatesRepositoryTest.php
View File

@ -34,8 +34,7 @@ class NewsletterTemplatesRepositoryTest extends \MailPoetTest {
public function testItCleansRecentlySent() { public function testItCleansRecentlySent() {
$total = NewsletterTemplatesRepository::RECENTLY_SENT_COUNT + 5; $total = NewsletterTemplatesRepository::RECENTLY_SENT_COUNT + 5;
for ($i = 0; $i < $total; $i++) { for ($i = 0; $i < $total; $i++) {
$template = new NewsletterTemplateEntity(); $template = new NewsletterTemplateEntity('Testing template ' . $i);
$template->setName('Testing template ' . $i);
$template->setBody(['key' => 'value']); $template->setBody(['key' => 'value']);
$template->setCategories(NewsletterTemplatesRepository::RECENTLY_SENT_CATEGORIES); $template->setCategories(NewsletterTemplatesRepository::RECENTLY_SENT_CATEGORIES);
$this->entityManager->persist($template); $this->entityManager->persist($template);