Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Adds client-side check for invalid characters in email addresses

Browse Source 
Adds server-side validation of email addresses using WP's is_email()
This commit is contained in:
Vlad
2017-06-04 17:38:28 -04:00
parent d27968a215
commit 7f566fb672
3 changed files with 77 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
tests/unit/Subscribers/ImportExport/Import/ImportTest.php
View File

@ -91,6 +91,55 @@ class ImportTest extends MailPoetTest {
}
}
function testItValidatesSubscribersEmail() {
$validation_rules = array('email' => 'email');
// invalid email is removed from data object
$data['email'] = array(
'àdam@smîth.com',
'jane@doe.com'
);
$result = $this->import->validateSubscribersData($data, $validation_rules);
expect($result['email'])->count(1);
expect($result['email'][0])->equals('jane@doe.com');
// valid email passes validation
$data['email'] = array(
'adam@smith.com',
'jane@doe.com'
);
$result = $this->import->validateSubscribersData($data, $validation_rules);
expect($result)->equals($data);
}
function testItThrowsErrorWhenNoValidSubscribersAreFoundDuringImport() {
$data = array(
'subscribers' => array(
array(
'Adam',
'Smith',
'àdam@smîth.com',
'France'
)
),
'columns' => array(
'first_name' => array('index' => 0),
'last_name' => array('index' => 1),
'email' => array('index' => 2)
),
'segments' => array(),
'timestamp' => time(),
'updateSubscribers' => true
);
$import = new Import($data);
try {
$import->process();
self::fail('No valid subscribers found exception not thrown.');
} catch(Exception $e) {
expect($e->getMessage())->equals('No valid subscribers were founds.');
}
}
function testItTransformsSubscribers() {
$custom_field = $this->subscribers_custom_fields[0];
expect($this->import->subscribers_data['first_name'][0])
@ -439,7 +488,6 @@ class ImportTest extends MailPoetTest {
expect($updated_subscriber->status)->equals('unsubscribed');
}
function testItRunsImport() {
$result = $this->import->process();
expect($result['created'])->equals(2);