Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

adding tests

Browse Source
This commit is contained in:
Amine Ben hammou
2018-03-16 15:08:18 +01:00
parent 1af242c2dd
commit 82ec8d7ef9
6 changed files with 571 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/Subscribers/ImportExport/Export/DefaultSubscribersGetter.php
View File

@ -44,7 +44,6 @@ class DefaultSubscribersGetter extends SubscribersGetter {
SubscriberSegment::$_table . '.segment_id' SubscriberSegment::$_table . '.segment_id'
) )
) )
->groupBy(Subscriber::$_table . '.id')
->groupBy(Segment::$_table . '.id'); ->groupBy(Segment::$_table . '.id');
if($this->get_subscribers_without_segment !== false) { if($this->get_subscribers_without_segment !== false) {

2
lib/Subscribers/ImportExport/Export/DynamicSubscribersGetter.php
View File

@ -22,7 +22,7 @@ class DynamicSubscribersGetter extends SubscribersGetter {
$segment_id = $this->segments_ids[$this->segment_index]; $segment_id = $this->segments_ids[$this->segment_index];
$filters = Hooks::applyFilters( $filters = Hooks::applyFilters(
'mailpoet_add_segment_filters', 'mailpoet_get_segment_filters',
$segment_id $segment_id
); );

1
lib/Subscribers/ImportExport/Export/SubscribersGetter.php
View File

@ -41,6 +41,7 @@ abstract class SubscribersGetter {
) )
) )
->filter('filterWithCustomFieldsForExport') ->filter('filterWithCustomFieldsForExport')
->groupBy(Subscriber::$_table . '.id')
->whereNull(Subscriber::$_table . '.deleted_at'); ->whereNull(Subscriber::$_table . '.deleted_at');
} }

275
tests/unit/Subscribers/ImportExport/Export/DefaultSubscribersGetterTest.php Normal file
View File

@ -0,0 +1,275 @@
<?php
namespace MailPoet\Test\Subscribers\ImportExport\Export;
use MailPoet\Models\CustomField;
use MailPoet\Models\Segment;
use MailPoet\Models\Subscriber;
use MailPoet\Models\SubscriberCustomField;
use MailPoet\Models\SubscriberSegment;
use MailPoet\Subscribers\ImportExport\Export\DefaultSubscribersGetter;
class DefaultSubscribersGetterTest extends \MailPoetTest {
function _before() {
$this->subscriber_fields = array(
'first_name' => 'First name',
'last_name' => 'Last name',
'email' => 'Email',
1 => 'Country'
);
$this->subscribers_data = array(
array(
'first_name' => 'Adam',
'last_name' => 'Smith',
'email' => 'adam@smith.com',
),
array(
'first_name' => 'Mary',
'last_name' => 'Jane',
'email' => 'mary@jane.com',
'status' => Subscriber::STATUS_SUBSCRIBED,
1 => 'Brazil'
),
array(
'first_name' => 'John',
'last_name' => 'Kookoo',
'email' => 'john@kookoo.com'
),
array(
'first_name' => 'Paul',
'last_name' => 'Newman',
'email' => 'paul@newman.com'
)
);
$this->custom_fields_data = array(
array(
'name' => 'Country',
'type' => 'text'
)
);
$this->segments_data = array(
array(
'name' => 'Newspapers'
),
array(
'name' => 'Journals'
)
);
foreach($this->subscribers_data as $subscriber) {
if(isset($subscriber[1])) {
unset($subscriber[1]);
}
$entity = Subscriber::create();
$entity->hydrate($subscriber);
$entity->save();
}
foreach($this->segments_data as $segment) {
$entity = Segment::create();
$entity->hydrate($segment);
$entity->save();
}
foreach($this->custom_fields_data as $custom_field) {
$entity = CustomField::create();
$entity->hydrate($custom_field);
$entity->save();
}
$entity = SubscriberCustomField::create();
$entity->subscriber_id = 2;
$entity->custom_field_id = 1;
$entity->value = $this->subscribers_data[1][1];
$entity->save();
$entity = SubscriberSegment::create();
$entity->subscriber_id = 1;
$entity->segment_id = 1;
$entity->status = Subscriber::STATUS_UNSUBSCRIBED;
$entity->save();
$entity = SubscriberSegment::create();
$entity->subscriber_id = 1;
$entity->segment_id = 2;
$entity->save();
$entity = SubscriberSegment::create();
$entity->subscriber_id = 2;
$entity->segment_id = 1;
$entity->save();
$entity = SubscriberSegment::create();
$entity->subscriber_id = 3;
$entity->segment_id = 2;
$entity->save();
}
protected function filterSubscribersData($subscribers) {
return array_map(function($subscriber) {
$data = array();
foreach($subscriber as $key => $value) {
if(in_array($key, array(
'first_name', 'last_name', 'email', 'global_status',
'status', 'list_status', 'segment_name', 1
)))
$data[$key] = $value;
}
return $data;
}, $subscribers);
}
function testItGetsSubscribersInOneSegment() {
$getter = new DefaultSubscribersGetter([1], 10);
$subscribers = $getter->get();
expect($this->filterSubscribersData($subscribers))->equals([
array(
'first_name' => 'Adam',
'last_name' => 'Smith',
'email' => 'adam@smith.com',
'status' => Subscriber::STATUS_UNCONFIRMED,
'global_status' => Subscriber::STATUS_UNCONFIRMED,
'list_status' => Subscriber::STATUS_UNSUBSCRIBED,
'segment_name' => 'Newspapers',
1 => null
),
array(
'first_name' => 'Mary',
'last_name' => 'Jane',
'email' => 'mary@jane.com',
'status' => Subscriber::STATUS_SUBSCRIBED,
'global_status' => Subscriber::STATUS_SUBSCRIBED,
'list_status' => Subscriber::STATUS_SUBSCRIBED,
'segment_name' => 'Newspapers',
1 => 'Brazil',
)
]);
expect($getter->get())->equals(false);
}
function testItGetsSubscribersInMultipleSegments() {
$getter = new DefaultSubscribersGetter([1, 2], 10);
$subscribers = $getter->get();
expect($this->filterSubscribersData($subscribers))->equals([
array(
'first_name' => 'Adam',
'last_name' => 'Smith',
'email' => 'adam@smith.com',
'status' => Subscriber::STATUS_UNCONFIRMED,
'global_status' => Subscriber::STATUS_UNCONFIRMED,
'list_status' => Subscriber::STATUS_UNSUBSCRIBED,
'segment_name' => 'Newspapers',
1 => null
),
array(
'first_name' => 'Adam',
'last_name' => 'Smith',
'email' => 'adam@smith.com',
'status' => Subscriber::STATUS_UNCONFIRMED,
'global_status' => Subscriber::STATUS_UNCONFIRMED,
'list_status' => Subscriber::STATUS_SUBSCRIBED,
'segment_name' => 'Journals',
1 => null
),
array(
'first_name' => 'Mary',
'last_name' => 'Jane',
'email' => 'mary@jane.com',
'status' => Subscriber::STATUS_SUBSCRIBED,
'global_status' => Subscriber::STATUS_SUBSCRIBED,
'list_status' => Subscriber::STATUS_SUBSCRIBED,
'segment_name' => 'Newspapers',
1 => 'Brazil',
),
array(
'first_name' => 'John',
'last_name' => 'Kookoo',
'email' => 'john@kookoo.com',
'status' => Subscriber::STATUS_UNCONFIRMED,
'global_status' => Subscriber::STATUS_UNCONFIRMED,
'list_status' => Subscriber::STATUS_SUBSCRIBED,
'segment_name' => 'Journals',
1 => null,
)
]);
expect($getter->get())->equals(false);
}
function testItGetsSubscribersInBatches() {
$getter = new DefaultSubscribersGetter([1, 2], 2);
expect($this->filterSubscribersData($getter->get()))->equals([
array(
'first_name' => 'Adam',
'last_name' => 'Smith',
'email' => 'adam@smith.com',
'status' => Subscriber::STATUS_UNCONFIRMED,
'global_status' => Subscriber::STATUS_UNCONFIRMED,
'list_status' => Subscriber::STATUS_UNSUBSCRIBED,
'segment_name' => 'Newspapers',
1 => null
),
array(
'first_name' => 'Adam',
'last_name' => 'Smith',
'email' => 'adam@smith.com',
'status' => Subscriber::STATUS_UNCONFIRMED,
'global_status' => Subscriber::STATUS_UNCONFIRMED,
'list_status' => Subscriber::STATUS_SUBSCRIBED,
'segment_name' => 'Journals',
1 => null
)
]);
expect($this->filterSubscribersData($getter->get()))->equals([
array(
'first_name' => 'Mary',
'last_name' => 'Jane',
'email' => 'mary@jane.com',
'status' => Subscriber::STATUS_SUBSCRIBED,
'global_status' => Subscriber::STATUS_SUBSCRIBED,
'list_status' => Subscriber::STATUS_SUBSCRIBED,
'segment_name' => 'Newspapers',
1 => 'Brazil',
),
array(
'first_name' => 'John',
'last_name' => 'Kookoo',
'email' => 'john@kookoo.com',
'status' => Subscriber::STATUS_UNCONFIRMED,
'global_status' => Subscriber::STATUS_UNCONFIRMED,
'list_status' => Subscriber::STATUS_SUBSCRIBED,
'segment_name' => 'Journals',
1 => null,
)
]);
expect($getter->get())->equals([]);
expect($getter->get())->equals(false);
}
function testItGetsSubscribersWithoutSegment() {
$getter = new DefaultSubscribersGetter([0], 10);
$subscribers = $getter->get();
expect($this->filterSubscribersData($subscribers))->equals([
array(
'first_name' => 'Paul',
'last_name' => 'Newman',
'email' => 'paul@newman.com',
'status' => Subscriber::STATUS_UNCONFIRMED,
'global_status' => Subscriber::STATUS_UNCONFIRMED,
'list_status' => null,
'segment_name' => 'Not In Segment',
1 => null
)
]);
}
function _after() {
\ORM::raw_execute('TRUNCATE ' . Subscriber::$_table);
\ORM::raw_execute('TRUNCATE ' . Segment::$_table);
\ORM::raw_execute('TRUNCATE ' . SubscriberSegment::$_table);
\ORM::raw_execute('TRUNCATE ' . CustomField::$_table);
\ORM::raw_execute('TRUNCATE ' . SubscriberCustomField::$_table);
}
}

278
tests/unit/Subscribers/ImportExport/Export/DynamicSubscribersGetterTest.php Normal file
View File

@ -0,0 +1,278 @@
<?php
namespace MailPoet\Test\Subscribers\ImportExport\Export;
use MailPoet\WP\Hooks;
use MailPoet\Models\CustomField;
use MailPoet\Models\Segment;
use MailPoet\Models\Subscriber;
use MailPoet\Models\SubscriberCustomField;
use MailPoet\Subscribers\ImportExport\Export\DynamicSubscribersGetter;
class DynamicSubscribersGetterTest extends \MailPoetTest {
function _before() {
$this->subscriber_fields = array(
'first_name' => 'First name',
'last_name' => 'Last name',
'email' => 'Email',
1 => 'Country'
);
$this->subscribers_data = array(
array(
'first_name' => 'Adam',
'last_name' => 'Smith',
'email' => 'adam@smith.com',
),
array(
'first_name' => 'Mary',
'last_name' => 'Jane',
'email' => 'mary@jane.com',
'status' => Subscriber::STATUS_SUBSCRIBED,
1 => 'Brazil'
),
array(
'first_name' => 'John',
'last_name' => 'Kookoo',
'email' => 'john@kookoo.com'
),
array(
'first_name' => 'Paul',
'last_name' => 'Newman',
'email' => 'paul@newman.com'
)
);
$this->custom_fields_data = array(
array(
'name' => 'Country',
'type' => 'text'
)
);
$this->segments_data = array(
array(
'name' => 'Newspapers'
),
array(
'name' => 'Journals'
)
);
foreach($this->subscribers_data as $subscriber) {
if(isset($subscriber[1])) {
unset($subscriber[1]);
}
$entity = Subscriber::create();
$entity->hydrate($subscriber);
$entity->save();
}
foreach($this->custom_fields_data as $custom_field) {
$entity = CustomField::create();
$entity->hydrate($custom_field);
$entity->save();
}
foreach($this->segments_data as $segment) {
$entity = Segment::create();
$entity->hydrate($segment);
$entity->save();
}
$entity = SubscriberCustomField::create();
$entity->subscriber_id = 2;
$entity->custom_field_id = 1;
$entity->value = $this->subscribers_data[1][1];
$entity->save();
Hooks::addAction(
'mailpoet_get_segment_filters',
function($segment_id) {
if($segment_id == 1) {
return array(new \DynamicSegmentFilter([1, 2]));
} else if($segment_id == 2) {
return array(new \DynamicSegmentFilter([1, 3, 4]));
}
return array();
}
);
}
protected function filterSubscribersData($subscribers) {
return array_map(function($subscriber) {
$data = array();
foreach($subscriber as $key => $value) {
if(in_array($key, array(
'first_name', 'last_name', 'email', 'global_status',
'status', 'list_status', 'segment_name', 1
)))
$data[$key] = $value;
}
return $data;
}, $subscribers);
}
function testItGetsSubscribersInOneSegment() {
$getter = new DynamicSubscribersGetter([1], 10);
$subscribers = $getter->get();
expect($this->filterSubscribersData($subscribers))->equals([
array(
'first_name' => 'Adam',
'last_name' => 'Smith',
'email' => 'adam@smith.com',
'status' => Subscriber::STATUS_UNCONFIRMED,
'global_status' => Subscriber::STATUS_UNCONFIRMED,
'list_status' => Subscriber::STATUS_UNCONFIRMED,
'segment_name' => 'Newspapers',
1 => null
),
array(
'first_name' => 'Mary',
'last_name' => 'Jane',
'email' => 'mary@jane.com',
'status' => Subscriber::STATUS_SUBSCRIBED,
'global_status' => Subscriber::STATUS_SUBSCRIBED,
'list_status' => Subscriber::STATUS_SUBSCRIBED,
'segment_name' => 'Newspapers',
1 => 'Brazil',
)
]);
expect($getter->get())->equals(false);
}
function testItGetsSubscribersInMultipleSegments() {
$getter = new DynamicSubscribersGetter([1, 2], 10);
expect($this->filterSubscribersData($getter->get()))->equals([
array(
'first_name' => 'Adam',
'last_name' => 'Smith',
'email' => 'adam@smith.com',
'status' => Subscriber::STATUS_UNCONFIRMED,
'global_status' => Subscriber::STATUS_UNCONFIRMED,
'list_status' => Subscriber::STATUS_UNCONFIRMED,
'segment_name' => 'Newspapers',
1 => null
),
array(
'first_name' => 'Mary',
'last_name' => 'Jane',
'email' => 'mary@jane.com',
'status' => Subscriber::STATUS_SUBSCRIBED,
'global_status' => Subscriber::STATUS_SUBSCRIBED,
'list_status' => Subscriber::STATUS_SUBSCRIBED,
'segment_name' => 'Newspapers',
1 => 'Brazil',
)
]);
expect($this->filterSubscribersData($getter->get()))->equals([
array(
'first_name' => 'Adam',
'last_name' => 'Smith',
'email' => 'adam@smith.com',
'status' => Subscriber::STATUS_UNCONFIRMED,
'global_status' => Subscriber::STATUS_UNCONFIRMED,
'list_status' => Subscriber::STATUS_UNCONFIRMED,
'segment_name' => 'Journals',
1 => null
),
array(
'first_name' => 'John',
'last_name' => 'Kookoo',
'email' => 'john@kookoo.com',
'status' => Subscriber::STATUS_UNCONFIRMED,
'global_status' => Subscriber::STATUS_UNCONFIRMED,
'list_status' => Subscriber::STATUS_UNCONFIRMED,
'segment_name' => 'Journals',
1 => null,
),
array(
'first_name' => 'Paul',
'last_name' => 'Newman',
'email' => 'paul@newman.com',
'status' => Subscriber::STATUS_UNCONFIRMED,
'global_status' => Subscriber::STATUS_UNCONFIRMED,
'list_status' => Subscriber::STATUS_UNCONFIRMED,
'segment_name' => 'Journals',
1 => null,
)
]);
expect($getter->get())->equals(false);
}
function testItGetsSubscribersInBatches() {
$getter = new DynamicSubscribersGetter([1, 2], 2);
expect($this->filterSubscribersData($getter->get()))->equals([
array(
'first_name' => 'Adam',
'last_name' => 'Smith',
'email' => 'adam@smith.com',
'status' => Subscriber::STATUS_UNCONFIRMED,
'global_status' => Subscriber::STATUS_UNCONFIRMED,
'list_status' => Subscriber::STATUS_UNCONFIRMED,
'segment_name' => 'Newspapers',
1 => null
),
array(
'first_name' => 'Mary',
'last_name' => 'Jane',
'email' => 'mary@jane.com',
'status' => Subscriber::STATUS_SUBSCRIBED,
'global_status' => Subscriber::STATUS_SUBSCRIBED,
'list_status' => Subscriber::STATUS_SUBSCRIBED,
'segment_name' => 'Newspapers',
1 => 'Brazil',
)
]);
expect($this->filterSubscribersData($getter->get()))->equals([]);
expect($this->filterSubscribersData($getter->get()))->equals([
array(
'first_name' => 'Adam',
'last_name' => 'Smith',
'email' => 'adam@smith.com',
'status' => Subscriber::STATUS_UNCONFIRMED,
'global_status' => Subscriber::STATUS_UNCONFIRMED,
'list_status' => Subscriber::STATUS_UNCONFIRMED,
'segment_name' => 'Journals',
1 => null
),
array(
'first_name' => 'John',
'last_name' => 'Kookoo',
'email' => 'john@kookoo.com',
'status' => Subscriber::STATUS_UNCONFIRMED,
'global_status' => Subscriber::STATUS_UNCONFIRMED,
'list_status' => Subscriber::STATUS_UNCONFIRMED,
'segment_name' => 'Journals',
1 => null,
)
]);
expect($this->filterSubscribersData($getter->get()))->equals([
array(
'first_name' => 'Paul',
'last_name' => 'Newman',
'email' => 'paul@newman.com',
'status' => Subscriber::STATUS_UNCONFIRMED,
'global_status' => Subscriber::STATUS_UNCONFIRMED,
'list_status' => Subscriber::STATUS_UNCONFIRMED,
'segment_name' => 'Journals',
1 => null,
)
]);
expect($getter->get())->equals(false);
}
function _after() {
\ORM::raw_execute('TRUNCATE ' . Subscriber::$_table);
\ORM::raw_execute('TRUNCATE ' . Segment::$_table);
\ORM::raw_execute('TRUNCATE ' . CustomField::$_table);
\ORM::raw_execute('TRUNCATE ' . SubscriberCustomField::$_table);
}
}

16
tests/unit/_bootstrap.php
View File

@ -1,5 +1,6 @@
<?php <?php
use Codeception\Util\Fixtures; use Codeception\Util\Fixtures;
use MailPoet\Models\Subscriber;
$newsletter_body_text = $newsletter_body_text =
@ -164,3 +165,18 @@ Fixtures::add(
), ),
) )
); );
/**
* Simple class mocking dynamic segment filter.
*/
class DynamicSegmentFilter {
protected $ids;
function __construct($ids) {
$this->ids = $ids;
}
public function toSql($orm) {
return $orm->whereIn(Subscriber::$_table . '.id', $this->ids);
}
}