Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Use method createOrUpdate from SegmentRepository in tests

Browse Source 
[MAILPOET-3167]
This commit is contained in:
Jan Lysý
2020-12-03 15:44:52 +01:00
committed by Veljko V
parent 79abec8f13
commit 83cb272555
7 changed files with 53 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tests/integration/API/JSON/v1/NewslettersTest.php
View File

@ -423,8 +423,8 @@ class NewslettersTest extends \MailPoetTest {
}
public function testItCanGetListingData() {
$segment1 = $this->createSegment('Segment 1');
$segment2 = $this->createSegment('Segment 2');
$segment1 = $this->segmentRepository->createOrUpdate('Segment 1');
$segment2 = $this->segmentRepository->createOrUpdate('Segment 2');
$this->createNewsletterSegment($this->newsletter, $segment1);
$this->createNewsletterSegment($this->newsletter, $segment2);
@ -458,8 +458,8 @@ class NewslettersTest extends \MailPoetTest {
public function testItCanFilterListing() {
// create 2 segments
$segment1 = $this->createSegment('Segment 1');
$segment2 = $this->createSegment('Segment 2');
$segment1 = $this->segmentRepository->createOrUpdate('Segment 1');
$segment2 = $this->segmentRepository->createOrUpdate('Segment 2');
// link standard newsletter to the 2 segments
$this->createNewsletterSegment($this->newsletter, $segment1);
@ -718,13 +718,6 @@ class NewslettersTest extends \MailPoetTest {
return $option;
}
private function createSegment(string $name): SegmentEntity {
$segment = new SegmentEntity($name, SegmentEntity::TYPE_DEFAULT, 'some description');
$this->segmentRepository->persist($segment);
$this->segmentRepository->flush();
return $segment;
}
private function createNewsletterSegment(
NewsletterEntity $newsletter,
SegmentEntity $segment

13
tests/integration/API/JSON/v1/SegmentsTest.php
View File

@ -45,9 +45,9 @@ class SegmentsTest extends \MailPoetTest {
$this->subscriberRepository = ContainerWrapper::getInstance()->get(SubscribersRepository::class);
$this->subscriberSegmentRepository = ContainerWrapper::getInstance()->get(SubscriberSegmentRepository::class);
$this->segment1 = $this->createSegment('Segment 1');
$this->segment2 = $this->createSegment('Segment 2');
$this->segment3 = $this->createSegment('Segment 3');
$this->segment1 = $this->segmentRepository->createOrUpdate('Segment 1');
$this->segment2 = $this->segmentRepository->createOrUpdate('Segment 2');
$this->segment3 = $this->segmentRepository->createOrUpdate('Segment 3');
}
public function testItCanGetASegment(): void {
@ -201,13 +201,6 @@ class SegmentsTest extends \MailPoetTest {
return $subscriberSegment;
}
private function createSegment(string $name): SegmentEntity {
$segment = new SegmentEntity($name, SegmentEntity::TYPE_DEFAULT, '');
$this->entityManager->persist($segment);
$this->entityManager->flush();
return $segment;
}
private function createSubsriber(string $email): SubscriberEntity {
$subscriber = new SubscriberEntity();
$subscriber->setEmail($email);