From 84f31484e98f79a9f0800d199c860121cf2821b8 Mon Sep 17 00:00:00 2001 From: Rostislav Wolny Date: Fri, 10 May 2019 10:15:24 +0200 Subject: [PATCH] Prevent automatic rescheduling of auth. emails check [MAILPOET-1987] --- lib/Cron/Workers/AuthorizedSendingEmailsCheck.php | 1 + .../Workers/AuthorizedSendingEmailsCheckTest.php | 13 +++++++++++++ 2 files changed, 14 insertions(+) diff --git a/lib/Cron/Workers/AuthorizedSendingEmailsCheck.php b/lib/Cron/Workers/AuthorizedSendingEmailsCheck.php index b3cc0eddf9..34ca5b21de 100644 --- a/lib/Cron/Workers/AuthorizedSendingEmailsCheck.php +++ b/lib/Cron/Workers/AuthorizedSendingEmailsCheck.php @@ -11,6 +11,7 @@ if (!defined('ABSPATH')) exit; class AuthorizedSendingEmailsCheck extends SimpleWorker { const TASK_TYPE = 'authorized_email_addresses_check'; + const AUTOMATIC_SCHEDULING = false; /** @var Bridge */ private $bridge; diff --git a/tests/integration/Cron/Workers/AuthorizedSendingEmailsCheckTest.php b/tests/integration/Cron/Workers/AuthorizedSendingEmailsCheckTest.php index 22121a330a..0a5f4a93d4 100644 --- a/tests/integration/Cron/Workers/AuthorizedSendingEmailsCheckTest.php +++ b/tests/integration/Cron/Workers/AuthorizedSendingEmailsCheckTest.php @@ -23,4 +23,17 @@ class AuthorizedSendingEmailsCheckTest extends \MailPoetTest { $worker = new AuthorizedSendingEmailsCheck($bridge_mock); $worker->processTaskStrategy(ScheduledTask::createOrUpdate([])); } + + function testItDoesNotScheduleAutomatically() { + $this->settings->set('mta_group', 'mailpoet'); + $this->settings->set('mta.method', 'MailPoet'); + $bridge_mock = $this->makeEmpty(Bridge::class, ['checkAuthorizedEmailAddresses' => Stub\Expected::never()]); + $worker = new AuthorizedSendingEmailsCheck($bridge_mock); + $worker->process(); + + $task = ScheduledTask::where('type', AuthorizedSendingEmailsCheck::TASK_TYPE) + ->where('status', ScheduledTask::STATUS_SCHEDULED) + ->findOne(); + expect($task)->false(); + } }