Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Removed unnecessary check in Newsletters endpoint

Browse Source 
[MAILPOET-2946]
This commit is contained in:
Jan Lysý
2020-10-22 19:01:18 +02:00
committed by Veljko V
parent c68728670e
commit 8569d4a86f
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/API/JSON/v1/Newsletters.php
View File

@ -161,14 +161,12 @@ class Newsletters extends APIEndpoint {
} }
$newsletter = $this->getNewsletter($data); $newsletter = $this->getNewsletter($data);
$this->newslettersRepository->prefetchOptions([$newsletter]);
if ($newsletter === null) { if ($newsletter === null) {
return $this->errorResponse([ return $this->errorResponse([
APIError::NOT_FOUND => __('This email does not exist.', 'mailpoet'), APIError::NOT_FOUND => __('This email does not exist.', 'mailpoet'),
]); ]);
} }
$this->newslettersRepository->prefetchOptions([$newsletter]);
$newsletter->setStatus($status); $newsletter->setStatus($status);
// if there are past due notifications, reschedule them for the next send date // if there are past due notifications, reschedule them for the next send date
@ -199,9 +197,7 @@ class Newsletters extends APIEndpoint {
} }
$this->newslettersRepository->flush(); $this->newslettersRepository->flush();
if (!$newsletter instanceof NewsletterEntity) {
return $this->errorResponse();
}
return $this->successResponse( return $this->successResponse(
$this->newslettersResponseBuilder->build($newsletter) $this->newslettersResponseBuilder->build($newsletter)
); );