Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Fix numeric select values not being passed as strings

Browse Source 
[MAILPOET-4323]
This commit is contained in:
Jan Jakes
2022-05-09 17:24:46 +02:00
committed by Veljko V
parent be9b6722e4
commit 8aa42b9ba0
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
mailpoet/assets/js/src/form_editor/components/form_settings/form_placement_options/settings_panels/cookie_settings.tsx
View File

@@ -21,15 +21,15 @@ export function CookieSettings({ settingsPlacementKey }: Props): JSX.Element {
value={formSettings.formPlacement[settingsPlacementKey].cookieExpiration} value={formSettings.formPlacement[settingsPlacementKey].cookieExpiration}
options={[ options={[
{ {
value: 0, value: '0',
label: MailPoet.I18n.t('formPlacementCookieExpirationAlways'), label: MailPoet.I18n.t('formPlacementCookieExpirationAlways'),
}, },
{ {
value: 1, value: '1',
label: MailPoet.I18n.t('formPlacementCookieExpirationDay'), label: MailPoet.I18n.t('formPlacementCookieExpirationDay'),
}, },
...cookieExpirationValues.map((cookieExpirationValue) => ({ ...cookieExpirationValues.map((cookieExpirationValue) => ({
value: cookieExpirationValue, value: `${cookieExpirationValue}`,
label: MailPoet.I18n.t('formPlacementCookieExpirationDays').replace( label: MailPoet.I18n.t('formPlacementCookieExpirationDays').replace(
'%1s', '%1s',
cookieExpirationValue.toString(), cookieExpirationValue.toString(),

2
mailpoet/assets/js/src/form_editor/components/form_settings/form_placement_options/settings_panels/fixed_bar_settings.tsx
View File

@@ -83,7 +83,7 @@ export function FixedBarSettings(): JSX.Element {
assocPath('formPlacement.fixedBar.delay', __, formSettings), assocPath('formPlacement.fixedBar.delay', __, formSettings),
])} ])}
options={delayValues.map((delayValue) => ({ options={delayValues.map((delayValue) => ({
value: delayValue, value: `${delayValue}`,
label: MailPoet.I18n.t('formPlacementDelaySeconds').replace( label: MailPoet.I18n.t('formPlacementDelaySeconds').replace(
'%1s', '%1s',
`${delayValue}`, `${delayValue}`,

2
mailpoet/assets/js/src/form_editor/components/form_settings/form_placement_options/settings_panels/popup_settings.tsx
View File

@@ -62,7 +62,7 @@ export function PopUpSettings(): JSX.Element {
assocPath('formPlacement.popup.delay', __, formSettings), assocPath('formPlacement.popup.delay', __, formSettings),
])} ])}
options={delayValues.map((delayValue) => ({ options={delayValues.map((delayValue) => ({
value: delayValue, value: `${delayValue}`,
label: MailPoet.I18n.t('formPlacementDelaySeconds').replace( label: MailPoet.I18n.t('formPlacementDelaySeconds').replace(
'%1s', '%1s',
`${delayValue}`, `${delayValue}`,

2
mailpoet/assets/js/src/form_editor/components/form_settings/form_placement_options/settings_panels/slide_in_settings.tsx
View File

@@ -83,7 +83,7 @@ export function SlideInSettings(): JSX.Element {
assocPath('formPlacement.slideIn.delay', __, formSettings), assocPath('formPlacement.slideIn.delay', __, formSettings),
])} ])}
options={delayValues.map((delayValue) => ({ options={delayValues.map((delayValue) => ({
value: delayValue, value: `${delayValue}`,
label: MailPoet.I18n.t('formPlacementDelaySeconds').replace( label: MailPoet.I18n.t('formPlacementDelaySeconds').replace(
'%1s', '%1s',
`${delayValue}`, `${delayValue}`,