Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove duplicated annotation for filter

Browse Source 
[MAILPOET-4717]
This commit is contained in:
Jan Lysý
2022-10-14 10:48:16 +02:00
committed by Veljko V
parent 47ee47c372
commit 8b1eabb765
1 changed files with 9 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
mailpoet/lib/API/MP/v1/Subscribers.php
View File

@ -247,18 +247,6 @@ class Subscribers {
return $this->subscribersResponseBuilder->build($subscriber); return $this->subscribersResponseBuilder->build($subscriber);
} }
/**
* @param array $filter {
* Optional. Filters to retrieve subscribers.
*
* @type string $status One of values: subscribed, unconfirmed, unsubscribed, inactive, bounced
* @type int $listId id of a list or dynamic segment
* @type \DateTime|int $minUpdatedAt DateTime object or timestamp of last update of subscriber.
* }
* @param int $limit
* @param int $offset
* @return array
*/
public function getSubscribers(array $filter, int $limit, int $offset): array { public function getSubscribers(array $filter, int $limit, int $offset): array {
$listingDefinition = $this->buildListingDefinition($filter, $limit, $offset); $listingDefinition = $this->buildListingDefinition($filter, $limit, $offset);
$subscribers = $this->subscriberListingRepository->getData($listingDefinition); $subscribers = $this->subscriberListingRepository->getData($listingDefinition);
@ -269,21 +257,20 @@ class Subscribers {
return $result; return $result;
} }
/**
* @param array $filter {
* Optional. Filters to retrieve subscribers.
*
* @type string $status One of values: subscribed, unconfirmed, unsubscribed, inactive, bounced
* @type int $listId id of a list or dynamic segment
* @type \DateTime|int $minUpdatedAt DateTime object or timestamp of last update of subscriber.
* }
* @return int
*/
public function getSubscribersCount(array $filter): int { public function getSubscribersCount(array $filter): int {
$listingDefinition = $this->buildListingDefinition($filter); $listingDefinition = $this->buildListingDefinition($filter);
return $this->subscriberListingRepository->getCount($listingDefinition); return $this->subscriberListingRepository->getCount($listingDefinition);
} }
/**
* @param array $filter {
* Filters to retrieve subscribers.
*
* @type string $status One of values: subscribed, unconfirmed, unsubscribed, inactive, bounced
* @type int $listId id of a list or dynamic segment
* @type \DateTime|int $minUpdatedAt DateTime object or timestamp of last update of subscriber.
* }
*/
private function buildListingDefinition(array $filter, int $limit = 50, int $offset = 0): ListingDefinition { private function buildListingDefinition(array $filter, int $limit = 50, int $offset = 0): ListingDefinition {
$group = isset($filter['status']) && is_string($filter['status']) ? $filter['status'] : null; $group = isset($filter['status']) && is_string($filter['status']) ? $filter['status'] : null;
$listingFilters = []; $listingFilters = [];