Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Add getAutomationsInTimespan method to controller

Browse Source 
[MAILPOET-5091]
This commit is contained in:
David Remer
2023-06-28 10:52:06 +03:00
committed by Aschepikov
parent 5e4631ec9d
commit 8b81016814
4 changed files with 25 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
mailpoet/lib/Automation/Integrations/MailPoet/Analytics/Controller/AutomationEmailController.php → mailpoet/lib/Automation/Integrations/MailPoet/Analytics/Controller/AutomationTimeSpanController.php
View File

@@ -8,8 +8,7 @@ use MailPoet\Automation\Integrations\MailPoet\Actions\SendEmailAction;
use MailPoet\Entities\NewsletterEntity;
use MailPoet\Newsletter\NewslettersRepository;
class AutomationEmailController {
class AutomationTimeSpanController {
/** @var AutomationStorage */
private $automationStorage;
@@ -25,13 +24,7 @@ class AutomationEmailController {
$this->newslettersRepository = $newslettersRepository;
}
/**
* @param Automation $automation
* @param \DateTimeImmutable $after
* @param \DateTimeImmutable $before
* @return NewsletterEntity[]
*/
public function getAutomationEmailsInTimeSpan(Automation $automation, \DateTimeImmutable $after, \DateTimeImmutable $before): array {
public function getAutomationsInTimespan(Automation $automation, \DateTimeImmutable $after, \DateTimeImmutable $before): array {
$automationVersions = $this->automationStorage->getAutomationVersionDates($automation->getId());
usort(
$automationVersions,
@@ -55,8 +48,18 @@ class AutomationEmailController {
$versionIds[] = (int)$automationVersion['id'];
}
$automations = $this->automationStorage->getAutomationWithDifferentVersions($versionIds);
return $this->getEmailsFromAutomations($automations);
return count($versionIds) > 0 ? $this->automationStorage->getAutomationWithDifferentVersions($versionIds) : [];
}
/**
* @param Automation $automation
* @param \DateTimeImmutable $after
* @param \DateTimeImmutable $before
* @return NewsletterEntity[]
*/
public function getAutomationEmailsInTimeSpan(Automation $automation, \DateTimeImmutable $after, \DateTimeImmutable $before): array {
$automations = $this->getAutomationsInTimespan($automation, $after, $before);
return count($automations) > 0 ? $this->getEmailsFromAutomations($automations) : [];
}
/**

12
mailpoet/lib/Automation/Integrations/MailPoet/Analytics/Controller/OverviewStatisticsController.php
View File

@@ -21,24 +21,24 @@ class OverviewStatisticsController {
/** @var NewsletterUrl */
private $newsletterUrl;
/** @var AutomationEmailController */
private $automationEmailController;
/** @var AutomationTimeSpanController */
private $automationTimeSpanController;
public function __construct(
NewslettersRepository $newslettersRepository,
NewsletterStatisticsRepository $newsletterStatisticsRepository,
NewsletterUrl $newsletterUrl,
AutomationEmailController $automationEmailController
AutomationTimeSpanController $automationTimeSpanController
) {
$this->newslettersRepository = $newslettersRepository;
$this->newsletterStatisticsRepository = $newsletterStatisticsRepository;
$this->newsletterUrl = $newsletterUrl;
$this->automationEmailController = $automationEmailController;
$this->automationTimeSpanController = $automationTimeSpanController;
}
public function getStatisticsForAutomation(Automation $automation, QueryWithCompare $query): array {
$currentEmails = $this->automationEmailController->getAutomationEmailsInTimeSpan($automation, $query->getAfter(), $query->getBefore());
$previousEmails = $this->automationEmailController->getAutomationEmailsInTimeSpan($automation, $query->getCompareWithAfter(), $query->getCompareWithBefore());
$currentEmails = $this->automationTimeSpanController->getAutomationEmailsInTimeSpan($automation, $query->getAfter(), $query->getBefore());
$previousEmails = $this->automationTimeSpanController->getAutomationEmailsInTimeSpan($automation, $query->getCompareWithAfter(), $query->getCompareWithBefore());
$data = [
'sent' => ['current' => 0, 'previous' => 0],
'opened' => ['current' => 0, 'previous' => 0],