Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Fix css linter

Browse Source 
[MAILPOET-2949]
This commit is contained in:
Pavel Dohnal
2020-06-15 15:54:18 +02:00
committed by Veljko V
parent d366b2e8f3
commit 8c3153e205
3 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
.circleci/config.yml
View File

@ -142,8 +142,8 @@ jobs:
- attach_workspace: - attach_workspace:
at: /home/circleci/mailpoet at: /home/circleci/mailpoet
- run: - run:
name: "QA JavaScript" name: "QA Frontend Assets"
command: ./do qa:javascript command: ./do qa:frontend-assets
qa_php: qa_php:
executor: wpcli_php_latest executor: wpcli_php_latest
steps: steps:

8
RoboFile.php
View File

@ -95,7 +95,7 @@ class RoboFile extends \Robo\Tasks {
// Clean up folder from previous files // Clean up folder from previous files
array_map('unlink', glob("assets/dist/css/*.*")); array_map('unlink', glob("assets/dist/css/*.*"));
$this->_exec('npm run stylelint -- "assets/css/src/components/**/*.scss"'); $this->_exec('npm run stylelint -- "assets/css/src/**/*.scss"');
$this->_exec('npm run scss'); $this->_exec('npm run scss');
$compilationResult = $this->_exec('npm run autoprefixer'); $compilationResult = $this->_exec('npm run autoprefixer');
@ -350,7 +350,7 @@ class RoboFile extends \Robo\Tasks {
public function qa() { public function qa() {
$collection = $this->collectionBuilder(); $collection = $this->collectionBuilder();
$collection->addCode([$this, 'qaPhp']); $collection->addCode([$this, 'qaPhp']);
$collection->addCode([$this, 'qaJavascript']); $collection->addCode([$this, 'qaFrontendAssets']);
return $collection->run(); return $collection->run();
} }
@ -363,7 +363,7 @@ class RoboFile extends \Robo\Tasks {
return $collection->run(); return $collection->run();
} }
public function qaJavascript() { public function qaFrontendAssets() {
$collection = $this->collectionBuilder(); $collection = $this->collectionBuilder();
$collection->addCode([$this, 'qaLintJavascript']); $collection->addCode([$this, 'qaLintJavascript']);
$collection->addCode([$this, 'qaLintCss']); $collection->addCode([$this, 'qaLintCss']);
@ -379,7 +379,7 @@ class RoboFile extends \Robo\Tasks {
} }
public function qaLintCss() { public function qaLintCss() {
return $this->_exec('npm run stylelint -- "assets/css/src/components/**/*.scss"'); return $this->_exec('npm run stylelint-check -- "assets/css/src/**/*.scss"');
} }
public function qaCodeSniffer($severity='errors') { public function qaCodeSniffer($severity='errors') {

1
package.json
View File

@ -18,6 +18,7 @@
"autoprefixer": "postcss assets/dist/css/*.css --use autoprefixer --no-map --replace", "autoprefixer": "postcss assets/dist/css/*.css --use autoprefixer --no-map --replace",
"scss": "node-sass assets/css/src/ --output assets/dist/css/ --output-style compact", "scss": "node-sass assets/css/src/ --output assets/dist/css/ --output-style compact",
"stylelint": "stylelint --fix", "stylelint": "stylelint --fix",
"stylelint-check": "stylelint",
"test": "env NODE_PATH=$NODE_PATH:./assets/js/src mocha --require tests/javascript/babel_register.js tests/javascript/**/*.spec.js", "test": "env NODE_PATH=$NODE_PATH:./assets/js/src mocha --require tests/javascript/babel_register.js tests/javascript/**/*.spec.js",
"check-types": "tsc --noEmit", "check-types": "tsc --noEmit",
"storybook": "start-storybook -s ./ -p 8083", "storybook": "start-storybook -s ./ -p 8083",