Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Merge pull request #977 from mailpoet/subscription_confirmation_update

Browse Source 
Prevents repeat subscription confirmation/duplicate welcome notifications [MAILPOET-988]
This commit is contained in:
stoletniy
2017-07-06 22:52:44 +03:00
committed by GitHub
parent 160b28a632 89da4c9aae
commit 9079d7d4db
4 changed files with 34 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/unit/Newsletter/Scheduler/SchedulerTest.php
View File

@ -62,6 +62,27 @@ class NewsletterSchedulerTest extends MailPoetTest {
expect(SendingQueue::findMany())->count(1);
}
function testItDoesNotCreateDuplicateWelcomeNotificationQueueRecords() {
$newsletter = (object)array(
'id' => 1,
'afterTimeNumber' => 2,
'afterTimeType' => 'hours'
);
$existing_subscriber = 678;
$existing_queue = SendingQueue::create();
$existing_queue->newsletter_id = $newsletter->id;
$existing_queue->subscribers = array('to_process' => array($existing_subscriber));
$existing_queue->save();
// queue is not scheduled
Scheduler::createWelcomeNotificationQueue($newsletter, $existing_subscriber);
expect(SendingQueue::findMany())->count(1);
// queue is not scheduled
Scheduler::createWelcomeNotificationQueue($newsletter, 1);
expect(SendingQueue::findMany())->count(2);
}
function testItCreatesWelcomeNotificationQueueRecord() {
$newsletter = (object)array(
'id' => 1,