Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Fix errors caught by translations code sniff

Browse Source 
[MAILPOET-4302]
This commit is contained in:
Rostislav Wolny
2022-08-09 14:56:48 +02:00
committed by Veljko V
parent 968cbb67d8
commit 90ff2db0d1
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
mailpoet/lib/API/JSON/v1/Settings.php
View File

@@ -304,7 +304,7 @@ class Settings extends APIEndpoint {
$response = $this->senderDomainController->getDomainRecords($domain); $response = $this->senderDomainController->getDomainRecords($domain);
} else { } else {
return $this->badRequest([ return $this->badRequest([
APIError::BAD_REQUEST => __($e->getMessage(), 'mailpoet'), APIError::BAD_REQUEST => $e->getMessage(),
]); ]);
} }
} }
@@ -333,7 +333,7 @@ class Settings extends APIEndpoint {
$response = ['ok' => true, 'dns' => $this->senderDomainController->getDomainRecords($domain)]; $response = ['ok' => true, 'dns' => $this->senderDomainController->getDomainRecords($domain)];
} else { } else {
return $this->badRequest([ return $this->badRequest([
APIError::BAD_REQUEST => __($e->getMessage(), 'mailpoet'), APIError::BAD_REQUEST => $e->getMessage(),
]); ]);
} }
} }
@@ -341,7 +341,7 @@ class Settings extends APIEndpoint {
if (!$response['ok']) { if (!$response['ok']) {
// sender domain verification error. probably an improper setup // sender domain verification error. probably an improper setup
return $this->badRequest([ return $this->badRequest([
APIError::BAD_REQUEST => __($response['error'] ?? 'failed sender domain verification', 'mailpoet'), APIError::BAD_REQUEST => $response['error'] ?? __('Sender domain verification failed.', 'mailpoet'),
], $response); ], $response);
} }

6
mailpoet/lib/Services/Bridge/API.php
View File

@@ -266,7 +266,8 @@ class API {
]; ];
$this->loggerFactory->getLogger(LoggerFactory::TOPIC_BRIDGE)->error('createAuthorizedSenderDomain API call failed.', $logData); $this->loggerFactory->getLogger(LoggerFactory::TOPIC_BRIDGE)->error('createAuthorizedSenderDomain API call failed.', $logData);
$fallbackError = sprintf(__('An error has happened while performing a request, the server has responded with response code %d'), $code); // translators: %d will be replaced by an error code
$fallbackError = sprintf(__('An error has happened while performing a request, the server has responded with response code %d', 'mailpoet'), $code);
$errorData = is_array($responseBody) && isset($responseBody['error']) ? $responseBody['error'] : $fallbackError; $errorData = is_array($responseBody) && isset($responseBody['error']) ? $responseBody['error'] : $fallbackError;
return ['error' => $errorData, 'status' => false]; return ['error' => $errorData, 'status' => false];
@@ -309,7 +310,8 @@ class API {
]; ];
$this->loggerFactory->getLogger(LoggerFactory::TOPIC_BRIDGE)->error('verifyAuthorizedSenderDomain API call failed.', $logData); $this->loggerFactory->getLogger(LoggerFactory::TOPIC_BRIDGE)->error('verifyAuthorizedSenderDomain API call failed.', $logData);
$fallbackError = sprintf(__('An error has happened while performing a request, the server has responded with response code %d'), $code); // translators: %d will be replaced by an error code
$fallbackError = sprintf(__('An error has happened while performing a request, the server has responded with response code %d', 'mailpoet'), $code);
$errorData = is_array($responseBody) && isset($responseBody['error']) ? $responseBody['error'] : $fallbackError; $errorData = is_array($responseBody) && isset($responseBody['error']) ? $responseBody['error'] : $fallbackError;
return ['error' => $errorData, 'status' => false]; return ['error' => $errorData, 'status' => false];