Refactor form bulk action to docrine

[MAILPOET-3630]
This commit is contained in:
Pavel Dohnal
2021-06-01 13:00:02 +02:00
committed by Veljko V
parent eb20c2031c
commit 9174bbb6fd
2 changed files with 57 additions and 23 deletions

View File

@ -8,6 +8,7 @@ use MailPoet\API\JSON\Error;
use MailPoet\API\JSON\Error as APIError;
use MailPoet\API\JSON\Response;
use MailPoet\API\JSON\ResponseBuilders\FormsResponseBuilder;
use MailPoet\API\JSON\SuccessResponse;
use MailPoet\Config\AccessControl;
use MailPoet\Entities\FormEntity;
use MailPoet\Form\ApiDataSanitizer;
@ -19,19 +20,15 @@ use MailPoet\Form\Listing\FormListingRepository;
use MailPoet\Form\PreviewPage;
use MailPoet\Listing;
use MailPoet\Settings\UserFlagsController;
use MailPoet\UnexpectedValueException;
use MailPoet\WP\Emoji;
use MailPoet\WP\Functions as WPFunctions;
class Forms extends APIEndpoint {
public $permissions = [
'global' => AccessControl::PERMISSION_MANAGE_FORMS,
];
/** @var Listing\BulkActionController */
private $bulkAction;
/** @var Listing\Handler */
private $listingHandler;
@ -63,7 +60,6 @@ class Forms extends APIEndpoint {
private $formSaveController;
public function __construct(
Listing\BulkActionController $bulkAction,
Listing\Handler $listingHandler,
UserFlagsController $userFlags,
FormFactory $formFactory,
@ -75,7 +71,6 @@ class Forms extends APIEndpoint {
ApiDataSanitizer $dataSanitizer,
FormSaveController $formSaveController
) {
$this->bulkAction = $bulkAction;
$this->listingHandler = $listingHandler;
$this->userFlags = $userFlags;
$this->formFactory = $formFactory;
@ -330,15 +325,20 @@ class Forms extends APIEndpoint {
}
}
public function bulkAction($data = []) {
try {
$meta = $this->bulkAction->apply('\MailPoet\Models\Form', $data);
return $this->successResponse(null, $meta);
} catch (\Exception $e) {
return $this->errorResponse([
$e->getCode() => $e->getMessage(),
]);
public function bulkAction($data = []): SuccessResponse {
$definition = $this->listingHandler->getListingDefinition($data['listing']);
$ids = $this->formListingRepository->getActionableIds($definition);
if ($data['action'] === 'trash') {
$this->formsRepository->bulkTrash($ids);
} elseif ($data['action'] === 'restore') {
$this->formsRepository->bulkRestore($ids);
} elseif ($data['action'] === 'delete') {
$this->formsRepository->bulkDelete($ids);
} else {
throw UnexpectedValueException::create()
->withErrors([APIError::BAD_REQUEST => "Invalid bulk action '{$data['action']}' provided."]);
}
return $this->successResponse(null, ['count' => count($ids)]);
}
private function getForm(array $data): ?FormEntity {

View File

@ -4,7 +4,6 @@ namespace MailPoet\Form;
use MailPoet\Doctrine\Repository;
use MailPoet\Entities\FormEntity;
use MailPoetVendor\Carbon\Carbon;
/**
* @extends Repository<FormEntity>
@ -37,21 +36,56 @@ class FormsRepository extends Repository {
}
public function delete(FormEntity $form) {
$this->remove($form);
$this->entityManager->remove($form);
$this->flush();
}
public function trash(FormEntity $form) {
$this->updateDeletedAt($form, Carbon::now());
$this->bulkTrash([$form->getId()]);
$this->entityManager->refresh($form);
}
public function restore(FormEntity $form) {
$this->updateDeletedAt($form, null);
$this->bulkRestore([$form->getId()]);
$this->entityManager->refresh($form);
}
private function updateDeletedAt(FormEntity $form, ?Carbon $value) {
$form->setDeletedAt($value);
$this->persist($form);
$this->flush();
public function bulkTrash(array $ids): int {
if (empty($ids)) {
return 0;
}
return $this->entityManager->createQueryBuilder()
->update(FormEntity::class, 'f')
->set('f.deletedAt', 'CURRENT_TIMESTAMP()')
->where('f.id IN (:ids)')
->setParameter('ids', $ids)
->getQuery()->execute();
}
public function bulkRestore(array $ids): int {
if (empty($ids)) {
return 0;
}
return $this->entityManager->createQueryBuilder()
->update(FormEntity::class, 'f')
->set('f.deletedAt', ':deletedAt')
->where('f.id IN (:ids)')
->setParameter('deletedAt', null)
->setParameter('ids', $ids)
->getQuery()->execute();
}
public function bulkDelete(array $ids): int {
if (empty($ids)) {
return 0;
}
return $this->entityManager->createQueryBuilder()
->delete(FormEntity::class, 'f')
->where('f.id IN (:ids)')
->setParameter('ids', $ids)
->getQuery()->execute();
}
}