Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Refactor repository to a property

Browse Source 
[MAILPOET-3267]
This commit is contained in:
Pavel Dohnal
2021-05-27 11:22:30 +02:00
committed by Veljko V
parent 70b2b3c40e
commit 917de80268
1 changed files with 9 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/integration/Newsletter/ViewInBrowser/ViewInBrowserRendererTest.php
View File

@ -45,7 +45,11 @@ class ViewInBrowserRendererTest extends \MailPoetTest {
/** @var SubscribersRepository */ /** @var SubscribersRepository */
private $subscribersRepository; private $subscribersRepository;
/** @var SendingQueuesRepository */
private $sendingQueueRepository;
public function _before() { public function _before() {
$this->sendingQueueRepository = $this->diContainer->get(SendingQueuesRepository::class);
$this->subscribersRepository = $this->diContainer->get(SubscribersRepository::class); $this->subscribersRepository = $this->diContainer->get(SubscribersRepository::class);
$newsletterData = [ $newsletterData = [
'body' => json_decode( 'body' => json_decode(
@ -166,26 +170,22 @@ class ViewInBrowserRendererTest extends \MailPoetTest {
$this->diContainer->get(Shortcodes::class), $this->diContainer->get(Shortcodes::class),
$this->diContainer->get(Renderer::class) $this->diContainer->get(Renderer::class)
); );
/** @var SendingQueuesRepository $sendingQueueRepository */
$sendingQueueRepository = $this->diContainer->get(SendingQueuesRepository::class);
$renderedBody = $viewInBrowser->render( $renderedBody = $viewInBrowser->render(
$preview = false, $preview = false,
$this->newsletter, $this->newsletter,
$this->subscriber, $this->subscriber,
$sendingQueueRepository->findOneById($this->sendingTask->queue()->id) $this->sendingQueueRepository->findOneById($this->sendingTask->queue()->id)
); );
expect($renderedBody)->regExp('/Newsletter from queue/'); expect($renderedBody)->regExp('/Newsletter from queue/');
} }
public function testItConvertsShortcodes() { public function testItConvertsShortcodes() {
/** @var SendingQueuesRepository $sendingQueueRepository */
$sendingQueueRepository = $this->diContainer->get(SendingQueuesRepository::class);
$this->settings->set('tracking.enabled', false); $this->settings->set('tracking.enabled', false);
$renderedBody = $this->viewInBrowserRenderer->render( $renderedBody = $this->viewInBrowserRenderer->render(
$preview = false, $preview = false,
$this->newsletter, $this->newsletter,
$this->subscriber, $this->subscriber,
$sendingQueueRepository->findOneById($this->sendingTask->queue()->id) $this->sendingQueueRepository->findOneById($this->sendingTask->queue()->id)
); );
expect($renderedBody)->stringContainsString('Hello, First'); expect($renderedBody)->stringContainsString('Hello, First');
expect($renderedBody)->stringContainsString(Router::NAME . '&endpoint=view_in_browser'); expect($renderedBody)->stringContainsString(Router::NAME . '&endpoint=view_in_browser');
@ -193,9 +193,7 @@ class ViewInBrowserRendererTest extends \MailPoetTest {
public function testItRewritesLinksToRouterEndpointWhenTrackingIsEnabled() { public function testItRewritesLinksToRouterEndpointWhenTrackingIsEnabled() {
$this->settings->set('tracking.enabled', true); $this->settings->set('tracking.enabled', true);
/** @var SendingQueuesRepository $sendingQueueRepository */ $queue = $this->sendingQueueRepository->findOneById($this->sendingTask->queue()->id);
$sendingQueueRepository = $this->diContainer->get(SendingQueuesRepository::class);
$queue = $sendingQueueRepository->findOneById($this->sendingTask->queue()->id);
$this->assertInstanceOf(SendingQueueEntity::class, $queue); $this->assertInstanceOf(SendingQueueEntity::class, $queue);
$queue->setNewsletterRenderedBody($this->queueRenderedNewsletterWithTracking); $queue->setNewsletterRenderedBody($this->queueRenderedNewsletterWithTracking);
$renderedBody = $this->viewInBrowserRenderer->render( $renderedBody = $this->viewInBrowserRenderer->render(
@ -208,9 +206,7 @@ class ViewInBrowserRendererTest extends \MailPoetTest {
} }
public function testItConvertsHashedLinksToUrlsWhenPreviewIsEnabledAndNewsletterWasSent() { public function testItConvertsHashedLinksToUrlsWhenPreviewIsEnabledAndNewsletterWasSent() {
/** @var SendingQueuesRepository $sendingQueueRepository */ $queue = $this->sendingQueueRepository->findOneById($this->sendingTask->queue()->id);
$sendingQueueRepository = $this->diContainer->get(SendingQueuesRepository::class);
$queue = $sendingQueueRepository->findOneById($this->sendingTask->queue()->id);
$this->assertInstanceOf(SendingQueueEntity::class, $queue); $this->assertInstanceOf(SendingQueueEntity::class, $queue);
$queue->setNewsletterRenderedBody($this->queueRenderedNewsletterWithTracking); $queue->setNewsletterRenderedBody($this->queueRenderedNewsletterWithTracking);
$renderedBody = $this->viewInBrowserRenderer->render( $renderedBody = $this->viewInBrowserRenderer->render(
@ -225,9 +221,7 @@ class ViewInBrowserRendererTest extends \MailPoetTest {
} }
public function testRemovesOpenTrackingTagWhenPreviewIsEnabledAndNewsletterWasSent() { public function testRemovesOpenTrackingTagWhenPreviewIsEnabledAndNewsletterWasSent() {
/** @var SendingQueuesRepository $sendingQueueRepository */ $queue = $this->sendingQueueRepository->findOneById($this->sendingTask->queue()->id);
$sendingQueueRepository = $this->diContainer->get(SendingQueuesRepository::class);
$queue = $sendingQueueRepository->findOneById($this->sendingTask->queue()->id);
$this->assertInstanceOf(SendingQueueEntity::class, $queue); $this->assertInstanceOf(SendingQueueEntity::class, $queue);
$queue->setNewsletterRenderedBody($this->queueRenderedNewsletterWithTracking); $queue->setNewsletterRenderedBody($this->queueRenderedNewsletterWithTracking);
$renderedBody = $this->viewInBrowserRenderer->render( $renderedBody = $this->viewInBrowserRenderer->render(