Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Run update query only once, use Builder minLength for name

Browse Source 
[MAILPOET-4422]
This commit is contained in:
alex-mailpoet
2022-07-15 09:41:23 +03:00
committed by Jan Jakeš
parent d3731c715b
commit 960e917b64
2 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
mailpoet/lib/Automation/Engine/Builder/UpdateWorkflowController.php
View File

@@ -27,15 +27,20 @@ class UpdateWorkflowController {
throw Exceptions::workflowNotFound($id);
}
$changed = false;
if (array_key_exists('name', $data)) {
$this->checkWorkflowName($data['name']);
$workflow->setName($data['name']);
$this->storage->updateWorkflow($workflow);
$changed = true;
}
if (array_key_exists('status', $data)) {
$this->checkWorkflowStatus($data['status']);
$workflow->setStatus($data['status']);
$changed = true;
}
if ($changed) {
$this->storage->updateWorkflow($workflow);
}
@@ -46,12 +51,6 @@ class UpdateWorkflowController {
return $workflow;
}
private function checkWorkflowName(string $name): void {
if (empty($name)) {
throw UnexpectedValueException::create()->withMessage(__('Workflow name must not be empty', 'mailpoet'));
}
}
private function checkWorkflowStatus(string $status): void {
if (!in_array($status, [Workflow::STATUS_ACTIVE, Workflow::STATUS_INACTIVE, Workflow::STATUS_DRAFT], true)) {
throw UnexpectedValueException::create()->withMessage(__(sprintf('Invalid status: %s', $status), 'mailpoet'));