Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Improve SchedulerTest::testItProcessesWelcomeNewsletterWhenWPUserIsVerified()

Browse Source 
Added NewsletterEntity::TYPE_WELCOME to make it correspond better to the fucntion name,
plus fixed a comment.

[MAILPOET-4375]
This commit is contained in:
Jan Jakes
2023-10-27 10:39:36 +02:00
committed by Aschepikov
parent a9db6ce12e
commit 96da9b3b9c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
mailpoet/tests/integration/Cron/Workers/SchedulerTest.php
View File

@@ -331,7 +331,7 @@ class SchedulerTest extends \MailPoetTest {
} }
public function testItProcessesWelcomeNewsletterWhenWPUserIsVerified() { public function testItProcessesWelcomeNewsletterWhenWPUserIsVerified() {
$newsletter = $this->_createNewsletter(); $newsletter = $this->_createNewsletter(NewsletterEntity::TYPE_WELCOME);
$subscriber = $this->_createSubscriber(); $subscriber = $this->_createSubscriber();
$this->newsletterOptionFactory->create($newsletter, 'event', 'user'); $this->newsletterOptionFactory->create($newsletter, 'event', 'user');
@@ -344,7 +344,7 @@ class SchedulerTest extends \MailPoetTest {
], $this); ], $this);
verify($task->getStatus())->notNull(); verify($task->getStatus())->notNull();
verify($scheduler->processWelcomeNewsletter($newsletter, $task))->true(); verify($scheduler->processWelcomeNewsletter($newsletter, $task))->true();
// update queue's status to null // update task status to null
$sendingQueue = $task->getSendingQueue(); $sendingQueue = $task->getSendingQueue();
$this->assertInstanceOf(SendingQueueEntity::class, $sendingQueue); $this->assertInstanceOf(SendingQueueEntity::class, $sendingQueue);
$scheduledTask = $this->scheduledTasksRepository->findOneBySendingQueue($sendingQueue); $scheduledTask = $this->scheduledTasksRepository->findOneBySendingQueue($sendingQueue);