Remove statements that cannot be executed

This commit is contained in:
Tautvidas Sipavičius
2016-06-29 19:20:50 +03:00
parent 9cfc2fd940
commit 9ddc1ef555
7 changed files with 3 additions and 31 deletions

View File

@@ -36,7 +36,6 @@ class Export {
'hspace="0"', 'hspace="0"',
'allowtransparency="true"></iframe>' 'allowtransparency="true"></iframe>'
)); ));
break;
case 'php': case 'php':
$output = array( $output = array(
@@ -44,7 +43,6 @@ class Export {
'echo $form_widget->widget(array(\'form\' => '.(int)$form['id'].', \'form_type\' => \'php\'));' 'echo $form_widget->widget(array(\'form\' => '.(int)$form['id'].', \'form_type\' => \'php\'));'
); );
return join("\n", $output); return join("\n", $output);
break;
case 'html': case 'html':
// TODO: get locale setting in order to load translations // TODO: get locale setting in order to load translations
@@ -82,11 +80,9 @@ class Export {
'form_type' => 'php' 'form_type' => 'php'
)); ));
return join("\n", $output); return join("\n", $output);
break;
case 'shortcode': case 'shortcode':
return '[mailpoet_form id="'.(int)$form['id'].'"]'; return '[mailpoet_form id="'.(int)$form['id'].'"]';
break;
} }
} }
} }

View File

@@ -28,7 +28,6 @@ class BulkAction {
throw new \Exception( throw new \Exception(
$this->model_class. ' has not method "'.$bulk_action_method.'"' $this->model_class. ' has not method "'.$bulk_action_method.'"'
); );
return false;
} }
return call_user_func_array( return call_user_func_array(
@@ -36,4 +35,4 @@ class BulkAction {
array($this->listing->getSelection(), $this->data) array($this->listing->getSelection(), $this->data)
); );
} }
} }

View File

@@ -26,7 +26,6 @@ class Link {
$url, $url,
__('Unsubscribe') __('Unsubscribe')
); );
break;
case 'subscription_unsubscribe_url': case 'subscription_unsubscribe_url':
return self::processUrl( return self::processUrl(
@@ -34,7 +33,6 @@ class Link {
SubscriptionUrl::getUnsubscribeUrl($subscriber), SubscriptionUrl::getUnsubscribeUrl($subscriber),
$queue $queue
); );
break;
case 'subscription_manage': case 'subscription_manage':
$url = self::processUrl( $url = self::processUrl(
@@ -47,7 +45,6 @@ class Link {
$url, $url,
__('Manage subscription') __('Manage subscription')
); );
break;
case 'subscription_manage_url': case 'subscription_manage_url':
return self::processUrl( return self::processUrl(
@@ -55,7 +52,6 @@ class Link {
SubscriptionUrl::getManageUrl($subscriber), SubscriptionUrl::getManageUrl($subscriber),
$queue $queue
); );
break;
case 'newsletter_view_in_browser': case 'newsletter_view_in_browser':
$action = 'newsletter_view_in_browser_url'; $action = 'newsletter_view_in_browser_url';
@@ -66,12 +62,10 @@ class Link {
$url, $url,
__('View in your browser') __('View in your browser')
); );
break;
case 'newsletter_view_in_browser_url': case 'newsletter_view_in_browser_url':
$url = NewsletterUrl::getViewInBrowserUrl($newsletter, $subscriber, $queue); $url = NewsletterUrl::getViewInBrowserUrl($newsletter, $subscriber, $queue);
return self::processUrl($action, $url, $queue); return self::processUrl($action, $url, $queue);
break;
default: default:
$shortcode = self::getShortcode($action); $shortcode = self::getShortcode($action);
@@ -85,7 +79,6 @@ class Link {
return ($url !== $shortcode) ? return ($url !== $shortcode) ?
self::processUrl($action, $url, $queue) : self::processUrl($action, $url, $queue) :
false; false;
break;
} }
} }

View File

@@ -17,18 +17,15 @@ class Newsletter {
switch($action) { switch($action) {
case 'subject': case 'subject':
return ($newsletter) ? $newsletter['subject'] : false; return ($newsletter) ? $newsletter['subject'] : false;
break;
case 'total': case 'total':
return substr_count($content, 'data-post-id'); return substr_count($content, 'data-post-id');
break;
case 'post_title': case 'post_title':
preg_match_all('/data-post-id="(\d+)"/ism', $content, $posts); preg_match_all('/data-post-id="(\d+)"/ism', $content, $posts);
$post_ids = array_unique($posts[1]); $post_ids = array_unique($posts[1]);
$latest_post = self::getLatestWPPost($post_ids); $latest_post = self::getLatestWPPost($post_ids);
return ($latest_post) ? $latest_post['post_title'] : false; return ($latest_post) ? $latest_post['post_title'] : false;
break;
case 'number': case 'number':
if($newsletter['type'] !== 'notification') return false; if($newsletter['type'] !== 'notification') return false;
@@ -37,11 +34,9 @@ class Newsletter {
->where('status', 'completed') ->where('status', 'completed')
->count(); ->count();
return ++$sent_newsletters; return ++$sent_newsletters;
break;
default: default:
return false; return false;
break;
} }
} }

View File

@@ -16,24 +16,19 @@ class Subscriber {
switch($action) { switch($action) {
case 'firstname': case 'firstname':
return ($subscriber) ? $subscriber['first_name'] : $default_value; return ($subscriber) ? $subscriber['first_name'] : $default_value;
break;
case 'lastname': case 'lastname':
return ($subscriber) ? $subscriber['last_name'] : $default_value; return ($subscriber) ? $subscriber['last_name'] : $default_value;
break;
case 'email': case 'email':
return ($subscriber) ? $subscriber['email'] : false; return ($subscriber) ? $subscriber['email'] : false;
break;
case 'displayname': case 'displayname':
if($subscriber && $subscriber['wp_user_id']) { if($subscriber && $subscriber['wp_user_id']) {
$wp_user = get_userdata($subscriber['wp_user_id']); $wp_user = get_userdata($subscriber['wp_user_id']);
return $wp_user->user_login; return $wp_user->user_login;
} }
return $default_value; return $default_value;
break;
case 'count': case 'count':
return SubscriberModel::filter('subscribed') return SubscriberModel::filter('subscribed')
->count(); ->count();
break;
default: default:
if(preg_match('/cf_(\d+)/', $action, $custom_field) && if(preg_match('/cf_(\d+)/', $action, $custom_field) &&
!empty($subscriber['id']) !empty($subscriber['id'])
@@ -45,7 +40,6 @@ class Subscriber {
return ($custom_field) ? $custom_field->value : false; return ($custom_field) ? $custom_field->value : false;
} }
return false; return false;
break;
} }
} }
} }

View File

@@ -87,16 +87,12 @@ class Pages {
switch($this->action) { switch($this->action) {
case 'confirm': case 'confirm':
return $this->getConfirmTitle(); return $this->getConfirmTitle();
break;
case 'manage': case 'manage':
return $this->getManageTitle(); return $this->getManageTitle();
break;
case 'unsubscribe': case 'unsubscribe':
return $this->getUnsubscribeTitle(); return $this->getUnsubscribeTitle();
break;
} }
} }
return $page_title; return $page_title;

View File

@@ -40,7 +40,6 @@ class Handlebars extends \Twig_Extension {
break; break;
default: default:
return; return;
break;
} }
$output = array(); $output = array();