Remove statements that cannot be executed

This commit is contained in:
Tautvidas Sipavičius
2016-06-29 19:20:50 +03:00
parent 9cfc2fd940
commit 9ddc1ef555
7 changed files with 3 additions and 31 deletions

View File

@@ -36,7 +36,6 @@ class Export {
'hspace="0"',
'allowtransparency="true"></iframe>'
));
break;
case 'php':
$output = array(
@@ -44,7 +43,6 @@ class Export {
'echo $form_widget->widget(array(\'form\' => '.(int)$form['id'].', \'form_type\' => \'php\'));'
);
return join("\n", $output);
break;
case 'html':
// TODO: get locale setting in order to load translations
@@ -82,11 +80,9 @@ class Export {
'form_type' => 'php'
));
return join("\n", $output);
break;
case 'shortcode':
return '[mailpoet_form id="'.(int)$form['id'].'"]';
break;
}
}
}

View File

@@ -28,7 +28,6 @@ class BulkAction {
throw new \Exception(
$this->model_class. ' has not method "'.$bulk_action_method.'"'
);
return false;
}
return call_user_func_array(

View File

@@ -26,7 +26,6 @@ class Link {
$url,
__('Unsubscribe')
);
break;
case 'subscription_unsubscribe_url':
return self::processUrl(
@@ -34,7 +33,6 @@ class Link {
SubscriptionUrl::getUnsubscribeUrl($subscriber),
$queue
);
break;
case 'subscription_manage':
$url = self::processUrl(
@@ -47,7 +45,6 @@ class Link {
$url,
__('Manage subscription')
);
break;
case 'subscription_manage_url':
return self::processUrl(
@@ -55,7 +52,6 @@ class Link {
SubscriptionUrl::getManageUrl($subscriber),
$queue
);
break;
case 'newsletter_view_in_browser':
$action = 'newsletter_view_in_browser_url';
@@ -66,12 +62,10 @@ class Link {
$url,
__('View in your browser')
);
break;
case 'newsletter_view_in_browser_url':
$url = NewsletterUrl::getViewInBrowserUrl($newsletter, $subscriber, $queue);
return self::processUrl($action, $url, $queue);
break;
default:
$shortcode = self::getShortcode($action);
@@ -85,7 +79,6 @@ class Link {
return ($url !== $shortcode) ?
self::processUrl($action, $url, $queue) :
false;
break;
}
}

View File

@@ -17,18 +17,15 @@ class Newsletter {
switch($action) {
case 'subject':
return ($newsletter) ? $newsletter['subject'] : false;
break;
case 'total':
return substr_count($content, 'data-post-id');
break;
case 'post_title':
preg_match_all('/data-post-id="(\d+)"/ism', $content, $posts);
$post_ids = array_unique($posts[1]);
$latest_post = self::getLatestWPPost($post_ids);
return ($latest_post) ? $latest_post['post_title'] : false;
break;
case 'number':
if($newsletter['type'] !== 'notification') return false;
@@ -37,11 +34,9 @@ class Newsletter {
->where('status', 'completed')
->count();
return ++$sent_newsletters;
break;
default:
return false;
break;
}
}

View File

@@ -16,24 +16,19 @@ class Subscriber {
switch($action) {
case 'firstname':
return ($subscriber) ? $subscriber['first_name'] : $default_value;
break;
case 'lastname':
return ($subscriber) ? $subscriber['last_name'] : $default_value;
break;
case 'email':
return ($subscriber) ? $subscriber['email'] : false;
break;
case 'displayname':
if($subscriber && $subscriber['wp_user_id']) {
$wp_user = get_userdata($subscriber['wp_user_id']);
return $wp_user->user_login;
}
return $default_value;
break;
case 'count':
return SubscriberModel::filter('subscribed')
->count();
break;
default:
if(preg_match('/cf_(\d+)/', $action, $custom_field) &&
!empty($subscriber['id'])
@@ -45,7 +40,6 @@ class Subscriber {
return ($custom_field) ? $custom_field->value : false;
}
return false;
break;
}
}
}

View File

@@ -87,16 +87,12 @@ class Pages {
switch($this->action) {
case 'confirm':
return $this->getConfirmTitle();
break;
case 'manage':
return $this->getManageTitle();
break;
case 'unsubscribe':
return $this->getUnsubscribeTitle();
break;
}
}
return $page_title;

View File

@@ -40,7 +40,6 @@ class Handlebars extends \Twig_Extension {
break;
default:
return;
break;
}
$output = array();