From 9e5acecbc0f18f65d0dbe2ecc939c07de0b12969 Mon Sep 17 00:00:00 2001
From: Amine Ben hammou <amine@mailpoet.com>
Date: Mon, 24 Feb 2020 19:16:37 +0100
Subject: [PATCH] Fix useNotices implementation

---
 assets/js/src/context/useNotices.jsx | 27 +++++++++++++++------------
 1 file changed, 15 insertions(+), 12 deletions(-)

diff --git a/assets/js/src/context/useNotices.jsx b/assets/js/src/context/useNotices.jsx
index 4f1c0dfad6..7a86688150 100644
--- a/assets/js/src/context/useNotices.jsx
+++ b/assets/js/src/context/useNotices.jsx
@@ -1,21 +1,24 @@
 import React from 'react';
 
 export default () => {
-  const [items, setItems] = React.useState([]);
-  const [nextId, setNextId] = React.useState(1);
-
-  const getNextId = React.useCallback(() => {
-    setNextId((x) => x + 1);
-    return nextId;
-  }, [nextId]);
+  const [state, setState] = React.useState({
+    items: [],
+    nextId: 1,
+  });
 
   const add = React.useCallback((item) => {
-    setItems((xs) => [...xs, { ...item, id: item.id || getNextId() }]);
-  }, [getNextId]);
+    setState(({ items, nextId }) => ({
+      items: [...items, { ...item, id: item.id || nextId }],
+      nextId: item.id ? nextId : nextId + 1,
+    }));
+  }, [setState]);
 
   const remove = React.useCallback((id) => {
-    setItems((xs) => xs.filter((x) => x.id !== id));
-  }, []);
+    setState(({ items, nextId }) => ({
+      items: items.filter((x) => x.id !== id),
+      nextId,
+    }));
+  }, [setState]);
 
   const success = React.useCallback(
     (content, props = {}) => add({ ...props, type: 'success', children: content }),
@@ -35,6 +38,6 @@ export default () => {
   );
 
   return {
-    items, success, info, warning, error, remove,
+    items: state.items, success, info, warning, error, remove,
   };
 };