Remove redundant code
[MAILPOET-5640]
This commit is contained in:
@ -3,7 +3,6 @@ import { State } from './types';
|
||||
import {
|
||||
getEditorLayout,
|
||||
getEditorSettings,
|
||||
getEmailStyles,
|
||||
getCdnUrl,
|
||||
isPremiumPluginActive,
|
||||
getEditorTheme,
|
||||
@ -24,7 +23,6 @@ export function getInitialState(): State {
|
||||
},
|
||||
postId,
|
||||
editorSettings: getEditorSettings(),
|
||||
styles: getEmailStyles(),
|
||||
layout: getEditorLayout(),
|
||||
theme: getEditorTheme(),
|
||||
autosaveInterval: 60,
|
||||
|
@ -164,8 +164,8 @@ export function getPreviewState(state: State): State['preview'] {
|
||||
return state.preview;
|
||||
}
|
||||
|
||||
export function getStyles(state: State): State['styles'] {
|
||||
return state.styles;
|
||||
export function getStyles(state: State): State['theme']['styles'] {
|
||||
return state.theme.styles;
|
||||
}
|
||||
|
||||
export function getLayout(state: State): State['layout'] {
|
||||
|
@ -1,13 +1,9 @@
|
||||
import { EmailEditorSettings, EmailStyles, EmailEditorLayout } from './types';
|
||||
import { EmailEditorSettings, EmailEditorLayout, EmailTheme } from './types';
|
||||
|
||||
export function getEditorSettings(): EmailEditorSettings {
|
||||
return window.MailPoetEmailEditor.editor_settings as EmailEditorSettings;
|
||||
}
|
||||
|
||||
export function getEmailStyles(): EmailStyles {
|
||||
return window.MailPoetEmailEditor.email_styles as EmailStyles;
|
||||
}
|
||||
|
||||
export function getEditorLayout(): EmailEditorLayout {
|
||||
return window.MailPoetEmailEditor.editor_layout as EmailEditorLayout;
|
||||
}
|
||||
@ -20,6 +16,6 @@ export function isPremiumPluginActive(): boolean {
|
||||
return window.MailPoetEmailEditor.is_premium_plugin_active;
|
||||
}
|
||||
|
||||
export function getEditorTheme(): EmailStyles {
|
||||
return window.MailPoetEmailEditor.editor_theme as EmailStyles;
|
||||
export function getEditorTheme(): EmailTheme {
|
||||
return window.MailPoetEmailEditor.editor_theme as EmailTheme;
|
||||
}
|
||||
|
@ -26,6 +26,11 @@ export type ExperimentalSettings = {
|
||||
|
||||
export type EmailEditorSettings = EditorSettings & ExperimentalSettings;
|
||||
|
||||
export type EmailTheme = {
|
||||
version: number;
|
||||
styles: EmailStyles;
|
||||
};
|
||||
|
||||
export type EmailStyles = {
|
||||
spacing: {
|
||||
blockGap: string;
|
||||
@ -73,9 +78,8 @@ export type State = {
|
||||
};
|
||||
postId: number;
|
||||
editorSettings: EmailEditorSettings;
|
||||
styles: EmailStyles;
|
||||
layout: EmailEditorLayout;
|
||||
theme: EmailStyles;
|
||||
theme: EmailTheme;
|
||||
autosaveInterval: number;
|
||||
cdnUrl: string;
|
||||
isPremiumPluginActive: boolean;
|
||||
|
@ -82,7 +82,6 @@ class EmailEditor {
|
||||
'is_premium_plugin_active' => (bool)$this->servicesChecker->isPremiumPluginActive(),
|
||||
'current_wp_user_email' => esc_js($currentUserEmail),
|
||||
'editor_settings' => $this->settingsController->getSettings(),
|
||||
'email_styles' => $this->settingsController->getEmailStyles(),
|
||||
'editor_layout' => $this->settingsController->getLayout(),
|
||||
'editor_theme' => $this->themeController->getTheme()->get_raw_data(),
|
||||
'bc_state' => $this->getBackwardCompatibilityState(),
|
||||
|
@ -5,22 +5,12 @@ namespace MailPoet\EmailEditor\Engine;
|
||||
use MailPoet\Validator\Builder;
|
||||
|
||||
class EmailApiController {
|
||||
/** @var SettingsController */
|
||||
private $settingsController;
|
||||
|
||||
public function __construct(
|
||||
SettingsController $settingsController
|
||||
) {
|
||||
$this->settingsController = $settingsController;
|
||||
}
|
||||
|
||||
/**
|
||||
* @return array - Email specific data such styles.
|
||||
*/
|
||||
public function getEmailData(): array {
|
||||
return [
|
||||
'layout_styles' => $this->settingsController->getEmailStyles(),
|
||||
];
|
||||
// Here comes code getting Email specific data that will be passed on 'email_data' attribute
|
||||
return [];
|
||||
}
|
||||
|
||||
/**
|
||||
@ -31,17 +21,6 @@ class EmailApiController {
|
||||
}
|
||||
|
||||
public function getEmailDataSchema(): array {
|
||||
return Builder::object([
|
||||
'layout_styles' => Builder::object([
|
||||
'width' => Builder::string(),
|
||||
'background' => Builder::string(),
|
||||
'padding' => Builder::object([
|
||||
'bottom' => Builder::string(),
|
||||
'left' => Builder::string(),
|
||||
'right' => Builder::string(),
|
||||
'top' => Builder::string(),
|
||||
]),
|
||||
]),
|
||||
])->toArray();
|
||||
return Builder::object()->toArray();
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user