Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Add more comments for clarification purposes

Browse Source 
MAILPOET-6365
This commit is contained in:
Oluwaseun Olorunsola
2025-01-09 14:40:13 +01:00
committed by Oluwaseun Olorunsola
parent cea59c8e38
commit a16f20b93d
4 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
mailpoet/assets/js/src/mailpoet-email-editor-integration/index.scss
View File

@ -1,5 +1,6 @@
// Core MailPoet styles. We need this here because the email editor does not register // Core MailPoet styles. We need this here because the email editor does not register
// under the mailpoet namespace and does not have access to the MailPoet plugin styles // under the mailpoet namespace and does not have access to the MailPoet plugin styles
// These styles are required by ReviewRequest (mailpoet/assets/js/src/review-request.tsx) feature
// Settings // Settings
// Global variables, config switches. Not producing any CSS. // Global variables, config switches. Not producing any CSS.

6
mailpoet/assets/js/src/mailpoet-email-editor-integration/index.ts
View File

@ -24,9 +24,9 @@ const EVENTS_TO_TRACK = [
'email_editor_events_rich_text_with_button_personalization_tags_shortcode_icon_clicked', // personalization_tags modal opened 'email_editor_events_rich_text_with_button_personalization_tags_shortcode_icon_clicked', // personalization_tags modal opened
'email_editor_events_personalization_tags_modal_tag_insert_button_clicked', // personalization_tags inserted 'email_editor_events_personalization_tags_modal_tag_insert_button_clicked', // personalization_tags inserted
'email_editor_events_rich_text_with_button_input_field_updated', // either subject or preheader updated 'email_editor_events_rich_text_with_button_input_field_updated', // either subject or preheader updated
'email_editor_events_styles_sidebar_screen_typography_opened', // styles sidebar was seen 'email_editor_events_styles_sidebar_screen_typography_opened', // styles sidebar-typography was seen
'email_editor_events_styles_sidebar_screen_colors_opened', // styles sidebar was seen 'email_editor_events_styles_sidebar_screen_colors_opened', // styles sidebar-colors was seen
'email_editor_events_styles_sidebar_screen_layout_opened', // styles sidebar was seen 'email_editor_events_styles_sidebar_screen_layout_opened', // styles sidebar-layout was seen
'email_editor_events_header_send_button_clicked', // Send button clicked 'email_editor_events_header_send_button_clicked', // Send button clicked
'email_editor_events_trash_modal_move_to_trash_button_clicked', // Move to trash button was clicked 'email_editor_events_trash_modal_move_to_trash_button_clicked', // Move to trash button was clicked
]; ];

4
packages/js/email-editor/src/components/block-editor/visual-editor/edit-template-blocks-notification.tsx
View File

@ -45,9 +45,7 @@ export default function EditTemplateBlocksNotification( { contentRef } ) {
return; return;
} }
setIsDialogOpen( true ); setIsDialogOpen( true );
recordEventOnce( 'edit_template_blocks_notification_opened', { recordEventOnce( 'edit_template_blocks_notification_opened' );
templateId,
} );
}; };
const canvas = contentRef.current; const canvas = contentRef.current;

2
packages/js/email-editor/src/components/styles-sidebar/screens/screen-colors.tsx
View File

@ -24,7 +24,7 @@ export function ScreenColors(): JSX.Element {
const handleOnChange = ( newStyles ) => { const handleOnChange = ( newStyles ) => {
updateStyles( newStyles ); updateStyles( newStyles );
recordEvent( 'styles_sidebar_screen_colors_styles_updated' ); recordEvent( 'styles_sidebar_screen_colors_styles_updated' ); // We can't log the updated color here because the onChange function returns the complete object.
}; };
return ( return (