Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Sanitize currentStateIndex

Browse Source 
[MAILPOET-1976]
This commit is contained in:
Ján Mikláš
2019-06-19 15:06:56 +02:00
committed by M. Shull
parent 66ee27c487
commit a198621104
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
assets/js/src/newsletter_editor/components/history.js
View File

@@ -67,14 +67,14 @@ Module.HistoryView = Marionette.View.extend({
}, },
canRedo: function canRedo() { canRedo: function canRedo() {
return this.model.currentStateIndex !== 0; return this.model.currentStateIndex > 0;
}, },
undo: function undo() { undo: function undo() {
if (!this.canUndo()) { if (!this.canUndo()) {
return; return;
} }
this.model.currentStateIndex += 1; this.model.currentStateIndex = Math.min(this.model.statesStack.length - 1, this.model.currentStateIndex + 1);
this.updateArrowsUI(); this.updateArrowsUI();
this.applyState(this.model.currentStateIndex); this.applyState(this.model.currentStateIndex);
}, },
@@ -83,7 +83,7 @@ Module.HistoryView = Marionette.View.extend({
if (!this.canRedo()) { if (!this.canRedo()) {
return; return;
} }
this.model.currentStateIndex -= 1; this.model.currentStateIndex = Math.max(0, this.model.currentStateIndex - 1);
this.updateArrowsUI(); this.updateArrowsUI();
this.applyState(this.model.currentStateIndex); this.applyState(this.model.currentStateIndex);
}, },