Replace expect()->array() with verify()->isArray()

codeception/verify 2.1 removed support for expect()->array() so we need
to replace it with verify()->isArray().

[MAILPOET-5664]
This commit is contained in:
Rodrigo Primo
2023-10-18 16:36:04 -03:00
committed by David Remer
parent c41e5c7d0f
commit a1f57361c5
17 changed files with 61 additions and 61 deletions

View File

@ -19,7 +19,7 @@ class DynamicSegmentsResponseBuilderTest extends \MailPoetTest {
/** @var DynamicSegmentsResponseBuilder $responseBuilder */
$responseBuilder = $this->diContainer->get(DynamicSegmentsResponseBuilder::class);
$response = $responseBuilder->build($segment);
expect($response)->array();
verify($response)->isArray();
verify($response['id'])->equals($segment->getId());
verify($response['name'])->equals($name);
verify($response['description'])->equals($description);
@ -28,7 +28,7 @@ class DynamicSegmentsResponseBuilderTest extends \MailPoetTest {
verify($response)->arrayHasKey('updated_at');
verify($response)->arrayHasKey('deleted_at');
verify($response['filters_connect'])->equals(DynamicSegmentFilterData::CONNECT_TYPE_AND);
expect($response['filters'])->array();
verify($response['filters'])->isArray();
verify($response['filters'])->arrayCount(1);
verify($response['filters'][0]['segmentType'])->equals(DynamicSegmentFilterData::TYPE_USER_ROLE);
verify($response['filters'][0]['wordpressRole'])->equals(['editor']);
@ -46,7 +46,7 @@ class DynamicSegmentsResponseBuilderTest extends \MailPoetTest {
/** @var DynamicSegmentsResponseBuilder $responseBuilder */
$responseBuilder = $this->diContainer->get(DynamicSegmentsResponseBuilder::class);
$response = $responseBuilder->build($segment);
expect($response)->array();
verify($response)->isArray();
verify($response['id'])->equals($segment->getId());
verify($response['name'])->equals($name);
verify($response['description'])->equals($description);
@ -55,7 +55,7 @@ class DynamicSegmentsResponseBuilderTest extends \MailPoetTest {
verify($response)->arrayHasKey('updated_at');
verify($response)->arrayHasKey('deleted_at');
verify($response['filters_connect'])->equals(DynamicSegmentFilterData::CONNECT_TYPE_AND);
expect($response['filters'])->array();
verify($response['filters'])->isArray();
verify($response['filters'])->arrayCount(2);
verify($response['filters'][0]['segmentType'])->equals(DynamicSegmentFilterData::TYPE_USER_ROLE);
verify($response['filters'][0]['wordpressRole'])->equals(['editor']);
@ -86,7 +86,7 @@ class DynamicSegmentsResponseBuilderTest extends \MailPoetTest {
/** @var DynamicSegmentsResponseBuilder $responseBuilder */
$responseBuilder = $this->diContainer->get(DynamicSegmentsResponseBuilder::class);
$response = $responseBuilder->buildForListing([$segment]);
expect($response)->array();
verify($response)->isArray();
verify($response[0]['name'])->equals($name);
verify($response[0]['description'])->equals($description);
verify($response[0]['type'])->equals(SegmentEntity::TYPE_DYNAMIC);

View File

@ -51,7 +51,7 @@ class SegmentsResponseBuilderTest extends \MailPoetTest {
$responseBuilder = $di->get(SegmentsResponseBuilder::class);
$response = $responseBuilder->buildForListing([$segment]);
expect($response)->array();
verify($response)->isArray();
verify($response[0]['name'])->equals($name);
verify($response[0]['type'])->equals(SegmentEntity::TYPE_DEFAULT);
expect($response[0]['subscribers_url'])->startsWith('http');

View File

@ -179,7 +179,7 @@ class NewslettersTest extends \MailPoetTest {
]));
$hookName = 'mailpoet_api_newsletters_get_after';
verify(WPHooksHelper::isFilterApplied($hookName))->true();
expect(WPHooksHelper::getFilterApplied($hookName)[0])->array();
verify(WPHooksHelper::getFilterApplied($hookName)[0])->isArray();
}
public function testItCanSaveANewsletter() {

View File

@ -116,7 +116,7 @@ class SendingQueueTest extends \MailPoetTest {
]);
$response = $sendingQueue->add(['newsletter_id' => $this->newsletter->getId()]);
$response = $response->getData();
expect($response['errors'][0])->array();
verify($response['errors'][0])->isArray();
verify($response['errors'][0]['message'])->stringContainsString('some error');
verify($response['errors'][0]['error'])->stringContainsString('bad_request');
}

View File

@ -92,12 +92,12 @@ class CustomFieldsTest extends \MailPoetTest {
'date_type' => 'year_month_day',
],
]);
expect($response)->array();
verify($response)->isArray();
verify($response)->arrayHasKey('id');
verify($response)->arrayHasKey('name');
verify($response)->arrayHasKey('type');
verify($response)->arrayHasKey('params');
expect($response['params'])->array();
verify($response['params'])->isArray();
}
public function testItFailsToCreateNewCustomField() {

View File

@ -44,7 +44,7 @@ class AutomationRunLogStorageTest extends \MailPoetTest {
'code',
'trace',
]);
expect($errors['trace'])->array();
verify($errors['trace'])->isArray();
expect(count($errors['trace']))->greaterThan(0);
}

View File

@ -190,7 +190,7 @@ class NewsletterTest extends \MailPoetTest {
$hookName = 'mailpoet_sending_newsletter_render_after_pre_process';
verify(WPHooksHelper::isFilterApplied($hookName))->true();
expect(WPHooksHelper::getFilterApplied($hookName)[0])->array();
verify(WPHooksHelper::getFilterApplied($hookName)[0])->isArray();
verify(WPHooksHelper::getFilterApplied($hookName)[1] instanceof NewsletterEntity)->true();
}
@ -212,7 +212,7 @@ class NewsletterTest extends \MailPoetTest {
$hookName = 'mailpoet_sending_newsletter_render_after_pre_process';
verify(WPHooksHelper::isFilterApplied($hookName))->true();
expect(WPHooksHelper::getFilterApplied($hookName)[0])->array();
verify(WPHooksHelper::getFilterApplied($hookName)[0])->isArray();
verify(WPHooksHelper::getFilterApplied($hookName)[1] instanceof NewsletterEntity)->true();
}
@ -610,7 +610,7 @@ class NewsletterTest extends \MailPoetTest {
verify($newsletterTask->preProcessNewsletter($this->newsletter, $this->sendingTask))->equals($this->newsletter);
$this->entityManager->refresh($sendingQueue);
$updatedMeta = $sendingQueue->getMeta();
expect($updatedMeta)->array();
verify($updatedMeta)->isArray();
verify($updatedMeta)->arrayHasKey('filterSegment');
$filterData = $updatedMeta['filterSegment']['filters'][0]['data'] ?? [];
verify($filterData['value'])->equals(50);

View File

@ -103,7 +103,7 @@ class JsonTypesTest extends \MailPoetTest {
$this->entityManager->flush();
$savedData = $this->connection->executeQuery("SELECT * FROM $this->tableName")->fetchAssociative() ?: [];
expect($savedData)->array();
verify($savedData)->isArray();
verify($savedData['json_data'])->null();
verify($savedData['json_or_serialized_data'])->null();
}

View File

@ -28,13 +28,13 @@ class HomepageDataControllerTest extends \MailPoetTest {
verify($data)->notEmpty();
verify($data['taskListDismissed'])->false();
verify($data['productDiscoveryDismissed'])->false();
expect($data['taskListStatus'])->array();
verify($data['taskListStatus'])->isArray();
verify($data['taskListStatus'])->notEmpty();
expect($data['productDiscoveryStatus'])->array();
verify($data['productDiscoveryStatus'])->isArray();
verify($data['productDiscoveryStatus'])->notEmpty();
expect($data['wooCustomersCount'])->int();
expect($data['subscribersCount'])->int();
expect($data['subscribersStats'])->array();
verify($data['subscribersStats'])->isArray();
verify($data['taskListStatus'])->notEmpty();
}

View File

@ -62,7 +62,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'some_mess' => 'mess',
];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -84,7 +84,7 @@ class FilterDataMapperTest extends \MailPoetTest {
]],
];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -108,7 +108,7 @@ class FilterDataMapperTest extends \MailPoetTest {
]],
];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -175,7 +175,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'some_mess' => 'mess',
]]];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -207,7 +207,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'some_mess' => 'mess',
]]];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -263,7 +263,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'some_mess' => 'mess',
]]];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -295,7 +295,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'days' => 3,
]]];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -318,7 +318,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'uselessParam' => 1,
]]];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -339,7 +339,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'operator' => 'less',
]]];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -388,7 +388,7 @@ class FilterDataMapperTest extends \MailPoetTest {
]]];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -428,7 +428,7 @@ class FilterDataMapperTest extends \MailPoetTest {
]]];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -465,7 +465,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'some_mess' => 'mess',
]]];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -522,7 +522,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'nonsense' => 1,
]]];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -564,7 +564,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'operator' => SubscriberScore::HIGHER_THAN,
'some' => 'mess',
]]]);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -596,7 +596,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'operator' => DynamicSegmentFilterData::OPERATOR_NONE,
'some' => 'mess',
]]]);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -653,7 +653,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'operator' => 'equals',
]]];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -690,7 +690,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'some_mess' => 'mess',
]]];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -713,7 +713,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'value' => 'some value',
]]];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -747,7 +747,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'form_ids' => ['1', '2'],
'operator' => DynamicSegmentFilterData::OPERATOR_ANY,
]]]);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -793,7 +793,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'automation_ids' => ['1', '2'],
]]];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -816,7 +816,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'automation_ids' => ['1', '2'],
]]];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -888,7 +888,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'timeframe' => 'inTheLast',
]]];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -915,7 +915,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'coupon_code_ids' => ['1', '5'],
]]];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);
@ -942,7 +942,7 @@ class FilterDataMapperTest extends \MailPoetTest {
'value' => '2023-07-01',
]]];
$filters = $this->mapper->map($data);
expect($filters)->array();
verify($filters)->isArray();
verify($filters)->arrayCount(1);
$filter = reset($filters);
$this->assertInstanceOf(DynamicSegmentFilterData::class, $filter);

View File

@ -80,7 +80,7 @@ class ConfirmationEmailCustomizerTest extends \MailPoetTest {
$controller = $this->generateController();
$newsletter = $controller->getNewsletter();
expect($newsletter->getBody())->array();
verify($newsletter->getBody())->isArray();
$stringBody = json_encode($newsletter->getBody());
verify($stringBody)->stringContainsString($this->partialTemplateContent);
}
@ -91,7 +91,7 @@ class ConfirmationEmailCustomizerTest extends \MailPoetTest {
$renderedContent = $controller->render($newsletter);
expect($renderedContent)->array();
verify($renderedContent)->isArray();
verify($renderedContent)->arrayHasKey('html');
verify($renderedContent)->arrayHasKey('text');

View File

@ -23,7 +23,7 @@ class NewsletterClicksExporterTest extends \MailPoetTest {
public function testExportWorksWhenSubscriberNotFound() {
$result = $this->exporter->export('email.that@doesnt.exists');
expect($result)->array();
verify($result)->isArray();
verify($result)->arrayHasKey('data');
verify($result['data'])->equals([]);
verify($result)->arrayHasKey('done');
@ -37,7 +37,7 @@ class NewsletterClicksExporterTest extends \MailPoetTest {
$this->entityManager->flush();
$result = $this->exporter->export('email.that@has.no.newsletters');
expect($result)->array();
verify($result)->isArray();
verify($result)->arrayHasKey('data');
verify($result['data'])->equals([]);
verify($result)->arrayHasKey('done');
@ -50,7 +50,7 @@ class NewsletterClicksExporterTest extends \MailPoetTest {
$this->prepareDataToBeExported($userEmail, $userAgentName);
$result = $this->exporter->export($userEmail);
expect($result['data'])->array();
verify($result['data'])->isArray();
verify($result['data'])->arrayCount(1);
verify($result['done'])->equals(true);
verify($result['data'][0])->arrayHasKey('group_id');

View File

@ -37,7 +37,7 @@ class NewslettersExporterTest extends \MailPoetTest {
public function testExportWorksWhenSubscriberNotFound() {
$result = $this->exporter->export('email.that@doesnt.exists');
expect($result)->array();
verify($result)->isArray();
verify($result)->arrayHasKey('data');
verify($result['data'])->equals([]);
verify($result)->arrayHasKey('done');
@ -47,7 +47,7 @@ class NewslettersExporterTest extends \MailPoetTest {
public function testExportWorksForSubscriberWithNoNewsletters() {
(new SubscriberFactory())->withEmail('email.that@has.no.newsletters')->create();
$result = $this->exporter->export('email.that@has.no.newsletters');
expect($result)->array();
verify($result)->isArray();
verify($result)->arrayHasKey('data');
verify($result['data'])->equals([]);
verify($result)->arrayHasKey('done');
@ -84,7 +84,7 @@ class NewslettersExporterTest extends \MailPoetTest {
$this->entityManager->flush();
$result = $this->exporter->export('user@with.newsletters');
expect($result['data'])->array();
verify($result['data'])->isArray();
verify($result['data'])->arrayCount(1);
verify($result['done'])->equals(true);
verify($result['data'][0])->arrayHasKey('group_id');

View File

@ -23,7 +23,7 @@ class SegmentsExporterTest extends \MailPoetTest {
public function testExportWorksWhenSubscriberNotFound() {
$result = $this->exporter->export('email.that@doesnt.exists');
expect($result)->array();
verify($result)->isArray();
verify($result)->arrayHasKey('data');
verify($result['data'])->equals([]);
verify($result)->arrayHasKey('done');
@ -33,7 +33,7 @@ class SegmentsExporterTest extends \MailPoetTest {
public function testExportWorksForSubscriberWithNoSegments() {
(new SubscriberFactory())->withEmail('email.that@has.no.segments')->create();
$result = $this->exporter->export('email.that@has.no.segments');
expect($result)->array();
verify($result)->isArray();
verify($result)->arrayHasKey('data');
verify($result['data'])->equals([]);
verify($result)->arrayHasKey('done');
@ -60,7 +60,7 @@ class SegmentsExporterTest extends \MailPoetTest {
$this->entityManager->refresh($subscriber);
$result = $this->exporter->export($subscriber->getEmail());
expect($result)->array();
verify($result)->isArray();
verify($result)->arrayHasKey('data');
verify($result)->arrayHasKey('done');
$expected = [
@ -91,7 +91,7 @@ class SegmentsExporterTest extends \MailPoetTest {
],
],
];
expect($result['data'])->array();
verify($result['data'])->isArray();
verify($result['data'])->arrayCount(2);
verify($result['done'])->equals(true);
verify($result['data'][0])->arrayHasKey('group_id');

View File

@ -30,7 +30,7 @@ class SubscriberExporterTest extends \MailPoetTest {
public function testExportWorksWhenSubscriberNotFound() {
$result = $this->exporter->export('email.that@doesnt.exists');
expect($result)->array();
verify($result)->isArray();
verify($result)->arrayHasKey('data');
verify($result['data'])->equals([]);
verify($result)->arrayHasKey('done');
@ -48,10 +48,10 @@ class SubscriberExporterTest extends \MailPoetTest {
->create();
$result = $this->exporter->export($email);
expect($result)->array();
verify($result)->isArray();
verify($result)->arrayHasKey('data');
verify($result)->arrayHasKey('done');
expect($result['data'])->array();
verify($result['data'])->isArray();
verify($result['data'])->arrayCount(1);
verify($result['done'])->equals(true);
verify($result['data'][0])->arrayHasKey('group_id');

View File

@ -28,7 +28,7 @@ class SubscriberPersonalDataEraserTest extends \MailPoetTest {
public function testExportWorksWhenSubscriberNotFound() {
$result = $this->eraser->erase('email.that@doesnt.exists');
expect($result)->array();
verify($result)->isArray();
verify($result)->arrayHasKey('items_removed');
verify($result['items_removed'])->equals(0);
verify($result)->arrayHasKey('done');

View File

@ -55,7 +55,7 @@ class ApiDataSanitizerTest extends \MailPoetUnitTest {
public function testItReturnsArray() {
$result = $this->sanitizer->sanitize(['name' => 'Name', 'type' => 'text']);
expect($result)->array();
verify($result)->isArray();
}
public function testItReturnsName() {
@ -135,7 +135,7 @@ class ApiDataSanitizerTest extends \MailPoetUnitTest {
],
]);
$values = $result['params']['values'];
expect($values)->array();
verify($values)->isArray();
verify($values)->arrayCount(2);
verify($values[0])->same(['value' => 'value 1', 'is_checked' => '']);
verify($values[1])->same(['value' => 'value 2', 'is_checked' => '1']);
@ -196,7 +196,7 @@ class ApiDataSanitizerTest extends \MailPoetUnitTest {
],
]);
$values = $result['params']['values'];
expect($values)->array();
verify($values)->isArray();
verify($values)->arrayCount(1);
verify($values[0])->same(['value' => 'value 1', 'is_checked' => '1']);
}