Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Add triggers under root rule for workflow validation

Browse Source 
[MAILPOET-4629]
This commit is contained in:
Jan Jakes
2022-09-14 15:12:25 +02:00
committed by David Remer
parent 325418e826
commit a3797b976a
2 changed files with 74 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
mailpoet/tests/unit/Automation/Engine/Validation/WorkflowRules/TriggersUnderRootRuleTest.php Normal file
View File

@@ -0,0 +1,34 @@
<?php declare(strict_types = 1);
namespace MailPoet\Automation\Engine\Validation\WorkflowRules;
require_once __DIR__ . '/WorkflowRuleTest.php';
use MailPoet\Automation\Engine\Data\Step;
use MailPoet\Automation\Engine\Data\Workflow;
use MailPoet\Automation\Engine\Exceptions\UnexpectedValueException;
use MailPoet\Automation\Engine\Validation\WorkflowGraph\WorkflowWalker;
class TriggersUnderRootRuleTest extends WorkflowRuleTest {
public function testItDetectsTriggersNotUnderRoot(): void {
$workflow = $this->make(Workflow::class, ['getSteps' => [
'root' => $this->createStep('root', Step::TYPE_ROOT, ['t', 'a']),
'a' => $this->createStep('a', Step::TYPE_ACTION, ['t']),
't' => $this->createStep('t', Step::TYPE_TRIGGER, []),
]]);
$this->expectException(UnexpectedValueException::class);
$this->expectExceptionMessage('Invalid workflow structure: Trigger must be a direct descendant of workflow root');
(new WorkflowWalker())->walk($workflow, [new TriggersUnderRootRule()]);
}
public function testItPassesWithTriggersUnderRoot(): void {
$workflow = $this->make(Workflow::class, ['getSteps' => [
'root' => $this->createStep('root', Step::TYPE_ROOT, ['t']),
't' => $this->createStep('t', Step::TYPE_TRIGGER, []),
]]);
(new WorkflowWalker())->walk($workflow, [new TriggersUnderRootRule()]);
// no exception thrown
}
}