- Modifies cron router/UI to display proper status message when WP task

scheduler is configured and cron is not running
- Updates sending queue worker and related components to stop (delete)
  cron when all processing is done

lib/Cron/CronHelper.php

@@ -12,6 +12,7 @@ class CronHelper {
   const DAEMON_EXECUTION_LIMIT = 20;
   const DAEMON_EXECUTION_TIMEOUT = 35;
   const DAEMON_REQUEST_TIMEOUT = 2;
+  const DAEMON_SETTING = 'cron_daemon';
 
   static function createDaemon($token) {
     $daemon = array(
@@ -23,17 +24,27 @@ class CronHelper {
   }
 
   static function getDaemon() {
-    return Setting::getValue('cron_daemon');
+    return Setting::getValue(self::DAEMON_SETTING);
   }
 
   static function saveDaemon($daemon) {
     $daemon['updated_at'] = time();
     return Setting::setValue(
-      'cron_daemon',
+      self::DAEMON_SETTING,
       $daemon
     );
   }
 
+  static function stopDaemon() {
+    $daemon = self::getDaemon();
+    $daemon['status'] = Daemon::STATUS_STOPPED;
+    return self::saveDaemon($daemon);
+  }
+
+  static function deleteDaemon() {
+    return Setting::deleteSetting(self::DAEMON_SETTING);
+  }
+
   static function createToken() {
     return Security::generateRandomString();
   }

lib/Cron/Workers/SendingQueue/Tasks/Newsletter.php

@@ -62,7 +62,7 @@ class Newsletter {
     return $newsletter;
   }
 
-  function render($newsletter) {
+  function render(array $newsletter) {
     $renderer = new Renderer($newsletter);
     $newsletter['rendered_body'] = $renderer->render();
     return $newsletter;
@@ -103,4 +103,12 @@ class Newsletter {
       )
     );
   }
-}
+
+  function markNewsletterAsSent($queue_id) {
+    $newsletter = NewsletterModel::findOne($queue_id);
+    // if it's a standard newsletter, update its status
+    if($newsletter->type === NewsletterModel::TYPE_STANDARD) {
+      $newsletter->setStatus(NewsletterModel::STATUS_SENT);
+    }
+  }
+}