Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Refactor listing handler to reusable service

Browse Source 
[MAILPOET-1689]
This commit is contained in:
Rostislav Wolny
2018-12-12 18:49:15 +01:00
parent fd4bcee5f5
commit a69ae0eea7
8 changed files with 132 additions and 144 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/API/JSON/v1/Forms.php
View File

@ -39,12 +39,8 @@ class Forms extends APIEndpoint {
}
function listing($data = array()) {
$listing = new Listing\Handler(
'\MailPoet\Models\Form',
$data
);
$listing_data = $listing->get();
$listing = new Listing\Handler();
$listing_data = $listing->get('\MailPoet\Models\Form', $data);
$data = array();
foreach($listing_data['items'] as $form) {

7
lib/API/JSON/v1/Newsletters.php
View File

@ -383,11 +383,8 @@ class Newsletters extends APIEndpoint {
}
function listing($data = array()) {
$listing = new Listing\Handler(
'\MailPoet\Models\Newsletter',
$data
);
$listing_data = $listing->get();
$listing = new Listing\Handler();
$listing_data = $listing->get('\MailPoet\Models\Newsletter', $data);
$data = array();
foreach($listing_data['items'] as $newsletter) {

8
lib/API/JSON/v1/Segments.php
View File

@ -36,12 +36,8 @@ class Segments extends APIEndpoint {
}
function listing($data = array()) {
$listing = new Listing\Handler(
'\MailPoet\Models\Segment',
$data
);
$listing_data = $listing->get();
$listing = new Listing\Handler();
$listing_data = $listing->get('\MailPoet\Models\Segment', $data);
$data = array();
foreach($listing_data['items'] as $segment) {

4
lib/API/JSON/v1/Subscribers.php
View File

@ -56,9 +56,9 @@ class Subscribers extends APIEndpoint {
function listing($data = array()) {
if(!isset($data['filter']['segment'])) {
$listing = new Listing\Handler('\MailPoet\Models\Subscriber', $data);
$listing = new Listing\Handler();
$listing_data = $listing->get();
$listing_data = $listing->get('\MailPoet\Models\Subscriber', $data);
} else {
$listings = new SubscribersListings();
$listing_data = $listings->getListingsInSegment($data);