Use SegmentEntity in endpoint Segment::save()

[MAILPOET-3167]

lib/API/JSON/v1/Segments.php

@@ -2,13 +2,16 @@
 
 namespace MailPoet\API\JSON\v1;
 
+use InvalidArgumentException;
 use MailPoet\API\JSON\Endpoint as APIEndpoint;
 use MailPoet\API\JSON\Error as APIError;
 use MailPoet\API\JSON\ResponseBuilders\SegmentsResponseBuilder;
 use MailPoet\Config\AccessControl;
+use MailPoet\Doctrine\Validator\ValidationException;
 use MailPoet\Entities\SegmentEntity;
 use MailPoet\Listing;
 use MailPoet\Models\Segment;
+use MailPoet\Segments\SegmentSaveController;
 use MailPoet\Segments\SegmentsRepository;
 use MailPoet\Segments\WooCommerce;
 use MailPoet\Segments\WP;
@@ -31,6 +34,9 @@ class Segments extends APIEndpoint {
   /** @var SegmentsResponseBuilder */
   private $segmentsResponseBuilder;
 
+  /** @var SegmentSaveController */
+  private $segmentSavecontroller;
+
   /** @var WooCommerce */
   private $wooCommerceSync;
 
@@ -42,6 +48,7 @@ class Segments extends APIEndpoint {
     Listing\Handler $listingHandler,
     SegmentsRepository $segmentsRepository,
     SegmentsResponseBuilder $segmentsResponseBuilder,
+    SegmentSaveController $segmentSavecontroller,
     WooCommerce $wooCommerce,
     WP $wpSegment
   ) {
@@ -50,6 +57,7 @@ class Segments extends APIEndpoint {
     $this->wooCommerceSync = $wooCommerce;
     $this->segmentsRepository = $segmentsRepository;
     $this->segmentsResponseBuilder = $segmentsResponseBuilder;
+    $this->segmentSavecontroller = $segmentSavecontroller;
     $this->wpSegment = $wpSegment;
   }
 
@@ -88,18 +96,19 @@ class Segments extends APIEndpoint {
   }
 
   public function save($data = []) {
-    $segment = Segment::createOrUpdate($data);
+    try {
-    $errors = $segment->getErrors();
+      $segment = $this->segmentSavecontroller->save($data);
-
+    } catch (ValidationException $exception) {
-    if (!empty($errors)) {
+      return $this->badRequest([
-      return $this->badRequest($errors);
+        APIError::BAD_REQUEST  => __('Please specify a name.', 'mailpoet'),
-    } else {
+      ]);
-      $segment = Segment::findOne($segment->id);
+    } catch (InvalidArgumentException $exception) {
-      if(!$segment instanceof Segment) return $this->errorResponse();
+      return $this->badRequest([
-      return $this->successResponse(
+        APIError::BAD_REQUEST  => __('Another record already exists. Please specify a different "name".', 'mailpoet'),
-        $segment->asArray()
+      ]);
-      );
     }
+    $response = $this->segmentsResponseBuilder->build($segment);
+    return $this->successResponse($response);
   }
 
   public function restore($data = []) {

lib/DI/ContainerConfigurator.php

@@ -255,6 +255,7 @@ class ContainerConfigurator implements IContainerConfigurator {
     $container->autowire(\MailPoet\Segments\SubscribersFinder::class)->setPublic(true);
     $container->autowire(\MailPoet\Segments\SegmentsRepository::class)->setPublic(true);
     $container->autowire(\MailPoet\Segments\SegmentSubscribersRepository::class)->setPublic(true);
+    $container->autowire(\MailPoet\Segments\SegmentSaveController::class)->setPublic(true);
     $container->autowire(\MailPoet\Segments\DynamicSegments\FilterHandler::class)->setPublic(true);
     $container->autowire(\MailPoet\Segments\DynamicSegments\Filters\EmailAction::class)->setPublic(true);
     $container->autowire(\MailPoet\Segments\DynamicSegments\Filters\UserRole::class)->setPublic(true);

lib/Segments/SegmentSaveController.php

@@ -0,0 +1,62 @@
+<?php
+
+namespace MailPoet\Segments;
+
+use InvalidArgumentException;
+use MailPoet\Entities\SegmentEntity;
+use MailPoet\NotFoundException;
+
+class SegmentSaveController {
+  /** @var SegmentsRepository */
+  private $segmentsRepository;
+
+  public function __construct(
+    SegmentsRepository $segmentsRepository
+  ) {
+    $this->segmentsRepository = $segmentsRepository;
+  }
+
+  public function save(array $data = []): SegmentEntity {
+    $this->checkSegmenUniqueName($data['name'] ?? '');
+
+    $segment = $this->createOrUpdateSegment($data);
+    return $segment;
+  }
+
+  private function checkSegmenUniqueName(string $name): void {
+    $segment = $this->segmentsRepository->findOneBy(['name' => $name]);
+    if ($segment) {
+      throw new InvalidArgumentException("Segment with name: '{$name}' already exists.");
+    }
+  }
+
+  private function createOrUpdateSegment(array $data): SegmentEntity {
+    $name = $data['name'] ?? '';
+    $description = $data['description'] ?? '';
+
+    if (isset($data['id'])) {
+      $segment = $this->getSegment((int)$data['id']);
+      $segment->setName($name);
+      $segment->setDescription($description);
+    } else {
+      $segment = new SegmentEntity(
+        $name,
+        SegmentEntity::TYPE_DEFAULT,
+        $description
+      );
+      $this->segmentsRepository->persist($segment);
+    }
+
+    $this->segmentsRepository->flush();
+    return $segment;
+  }
+
+  private function getSegment(int $segmentId): SegmentEntity {
+    $segment = $this->segmentsRepository->findOneById($segmentId);
+    if (!$segment) {
+      throw new NotFoundException();
+    }
+
+    return $segment;
+  }
+}