diff --git a/.eslintrc.es6.json b/.eslintrc.es6.json index 3d46bd8465..ced7d71c82 100644 --- a/.eslintrc.es6.json +++ b/.eslintrc.es6.json @@ -22,6 +22,7 @@ "react-hooks/rules-of-hooks": "error", "react-hooks/exhaustive-deps": "warn", // Exceptions + "arrow-parens": ["error", "always"], "comma-dangle": ["error", "always-multiline"], "no-script-url": 0, "import/extensions": 0, // we wouldn't be able to import jQuery without this line diff --git a/assets/js/src/announcements/feature_announcement.jsx b/assets/js/src/announcements/feature_announcement.jsx index bc1ceae260..10102cc9d3 100644 --- a/assets/js/src/announcements/feature_announcement.jsx +++ b/assets/js/src/announcements/feature_announcement.jsx @@ -23,7 +23,7 @@ class FeatureAnnouncement extends React.Component { const updateMailPoetNotice = ReactStringReplace( MailPoet.I18n.t('updateMailPoetNotice'), /\[link\](.*?)\[\/link\]/, - match => `${match}` + (match) => `${match}` ).join(''); jQuery('#beamerOverlay').append( `

${updateMailPoetNotice}

` diff --git a/assets/js/src/common/key_value_table.jsx b/assets/js/src/common/key_value_table.jsx index 94ae2af000..de7b8ffa17 100644 --- a/assets/js/src/common/key_value_table.jsx +++ b/assets/js/src/common/key_value_table.jsx @@ -1,10 +1,10 @@ import PropTypes from 'prop-types'; import React from 'react'; -const KeyValueTable = props => ( +const KeyValueTable = (props) => ( - {props.rows.map(row => ( + {props.rows.map((row) => ( diff --git a/assets/js/src/common/print_boolean.jsx b/assets/js/src/common/print_boolean.jsx index eb7cd0c432..0508e9ce1d 100644 --- a/assets/js/src/common/print_boolean.jsx +++ b/assets/js/src/common/print_boolean.jsx @@ -2,7 +2,7 @@ import PropTypes from 'prop-types'; import React from 'react'; import MailPoet from 'mailpoet'; -const PrintBoolean = props => ( +const PrintBoolean = (props) => ( {(props.children === true && props.truthy) || (props.children === false && props.falsy) diff --git a/assets/js/src/common/stepped_progess_bar.jsx b/assets/js/src/common/stepped_progess_bar.jsx index d16c72e0b0..4259b2d795 100644 --- a/assets/js/src/common/stepped_progess_bar.jsx +++ b/assets/js/src/common/stepped_progess_bar.jsx @@ -8,7 +8,7 @@ const SteppedProgressBar = (props) => { return (
{ - [...Array(props.steps_count).keys()].map(step => ( + [...Array(props.steps_count).keys()].map((step) => (
{ * @param {String} url * @return {Promise} DataURL of the generated image. */ -export const fromUrl = url => new Promise((resolve, reject) => { +export const fromUrl = (url) => new Promise((resolve, reject) => { const iframe = document.createElement('iframe'); const protocol = document.location.href.startsWith('https://') ? 'https:' : 'http:'; iframe.src = protocol + url.replace(/^https?:/, ''); @@ -59,7 +59,7 @@ export const fromUrl = url => new Promise((resolve, reject) => { * @param {Object} data * @return {Promise} DataURL of the generated image. */ -export const fromNewsletter = data => new Promise((resolve, reject) => { +export const fromNewsletter = (data) => new Promise((resolve, reject) => { const json = data; if (!_.isUndefined(json.body)) { json.body = JSON.stringify(json.body); @@ -69,7 +69,7 @@ export const fromNewsletter = data => new Promise((resolve, reject) => { endpoint: 'newsletters', action: 'showPreview', data: json, - }).done(response => fromUrl(response.meta.preview_url) + }).done((response) => fromUrl(response.meta.preview_url) .then(resolve) - .catch(reject)).fail(response => reject(response.errors)); + .catch(reject)).fail((response) => reject(response.errors)); }); diff --git a/assets/js/src/experimental_features/experimental_features.jsx b/assets/js/src/experimental_features/experimental_features.jsx index 570d0a547e..8e4c6b25ff 100644 --- a/assets/js/src/experimental_features/experimental_features.jsx +++ b/assets/js/src/experimental_features/experimental_features.jsx @@ -16,7 +16,7 @@ const ExperimentalFeatures = () => { }).fail((response) => { if (response.errors.length > 0) { MailPoet.Notice.error( - response.errors.map(error => error.message), + response.errors.map((error) => error.message), { scroll: true } ); } @@ -42,7 +42,7 @@ const ExperimentalFeatures = () => { }).fail((response) => { if (response.errors.length > 0) { MailPoet.Notice.error( - response.errors.map(error => error.message), + response.errors.map((error) => error.message), { scroll: true } ); } diff --git a/assets/js/src/form/fields/checkbox.jsx b/assets/js/src/form/fields/checkbox.jsx index 6c4ae933b2..ac12fb939c 100644 --- a/assets/js/src/form/fields/checkbox.jsx +++ b/assets/js/src/form/fields/checkbox.jsx @@ -22,7 +22,7 @@ class FormFieldCheckbox extends React.Component { // it will be false in case value is "0" or empty const isChecked = !!(Number(this.props.item[this.props.field.name])); const options = Object.keys(this.props.field.values).map( - value => ( + (value) => (

{ row.key } { row.value }