Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Add logging for unexpected states when we reach the end of sending

Browse Source 
[MAILPOET-5881]
This commit is contained in:
Rostislav Wolny
2024-05-31 12:29:52 +02:00
committed by Aschepikov
parent 9dd808a070
commit a7df6b496f
2 changed files with 47 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
mailpoet/tests/integration/Cron/Workers/SendingQueue/SendingQueueTest.php
View File

@@ -16,6 +16,7 @@ use MailPoet\Cron\Workers\SendingQueue\Tasks\Mailer as MailerTask;
use MailPoet\Cron\Workers\SendingQueue\Tasks\Newsletter as NewsletterTask;
use MailPoet\Cron\Workers\StatsNotifications\Scheduler as StatsNotificationsScheduler;
use MailPoet\DI\ContainerWrapper;
use MailPoet\Entities\LogEntity;
use MailPoet\Entities\NewsletterEntity;
use MailPoet\Entities\NewsletterLinkEntity;
use MailPoet\Entities\NewsletterSegmentEntity;
@@ -54,6 +55,7 @@ use MailPoet\Test\DataFactories\Subscriber as SubscriberFactory;
use MailPoet\Util\Security;
use MailPoet\WP\Functions as WPFunctions;
use MailPoetVendor\Carbon\Carbon;
use MailPoetVendor\Monolog\Logger;
class SendingQueueTest extends \MailPoetTest {
/** @var SendingQueueWorker */
@@ -1459,6 +1461,36 @@ class SendingQueueTest extends \MailPoetTest {
verify($newsletter->getStatus())->equals(NewsletterEntity::STATUS_SENDING);
}
public function testItLogsWhenSendingReachesEndAndTaskHasAnUnexpectedState() {
// No subscribers in queue to skip batch processing
$this->scheduledTaskSubscribersRepository->setSubscribers(
$this->scheduledTask,
[]
);
// To emulate unexpected task status change we switch task status to paused in mailer task mock
$task = $this->scheduledTask;
$em = $this->entityManager;
$mailerTaskMock = $this->createMock(MailerTask::class);
$mailerTaskMock
->expects($this->once())
->method('configureMailer')
->willReturnCallback(function() use ($task, $em) {
$task->setStatus(ScheduledTaskEntity::STATUS_PAUSED);
$em->flush();
});
$sendingQueueWorker = $this->getSendingQueueWorker($mailerTaskMock);
$sendingQueueWorker->process();
$logs = $this->entityManager->getRepository(LogEntity::class)->findAll();
$log = $logs[0] ?? null;
$this->assertInstanceOf(LogEntity::class, $log);
verify($log->getLevel())->equals(Logger::ERROR);
verify($log->getMessage())->stringContainsString('Sending task reached end of processing in sending queue worker in an unexpected state.');
verify($log->getMessage())->stringContainsString('"task_id":' . $task->getId());
}
public function testProcessMarksScheduledTaskInProgressAsFalseWhenProperlyProcessingTask() {
$sendingQueueWorker = $this->getSendingQueueWorker();
$sendingQueueWorker->process();
@@ -1600,7 +1632,7 @@ class SendingQueueTest extends \MailPoetTest {
$this->sendingQueuesRepository,
$this->entityManager,
$this->statisticsNewslettersRepository,
$authorizedEmailControllerMock ?? $this->authorizedEmailsController
$authorizedEmailControllerMock ?? $this->authorizedEmailsController,
);
}