Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Collect all step error types instead of terminating on the first one

Browse Source 
[MAILPOET-4659]
This commit is contained in:
Jan Jakes
2022-10-06 10:02:53 +02:00
committed by Jan Jakeš
parent 04ca19296b
commit a82896e794
7 changed files with 188 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

109
mailpoet/tests/unit/Automation/Engine/Validation/WorkflowRules/ValidStepRuleTest.php Normal file
View File

@@ -0,0 +1,109 @@
<?php declare(strict_types = 1);
namespace MailPoet\Automation\Engine\Validation\WorkflowRules;
require_once __DIR__ . '/WorkflowRuleTest.php';
use Codeception\Stub\Expected;
use Exception;
use MailPoet\Automation\Engine\Data\Step;
use MailPoet\Automation\Engine\Data\Workflow;
use MailPoet\Automation\Engine\Exceptions\UnexpectedValueException;
use MailPoet\Automation\Engine\Validation\WorkflowGraph\WorkflowNodeVisitor;
use MailPoet\Automation\Engine\Validation\WorkflowGraph\WorkflowWalker;
class ValidStepRuleTest extends WorkflowRuleTest {
public function testItRunsStepValidation(): void {
$workflow = $this->getWorkflow();
$workflow->setStatus(Workflow::STATUS_ACTIVE);
$rule = new ValidStepRule([
$this->makeEmpty(WorkflowNodeVisitor::class, [
'initialize' => Expected::once(),
'visitNode' => Expected::once(),
'complete' => Expected::once(),
])
]);
(new WorkflowWalker())->walk($workflow, [$rule]);
}
public function testItCollectsRecognizedErrors(): void {
$workflow = $this->getWorkflow();
$workflow->setStatus(Workflow::STATUS_ACTIVE);
$rule = new ValidStepRule([
$this->makeEmpty(WorkflowNodeVisitor::class, [
'visitNode' => Expected::once(function () {
throw UnexpectedValueException::create()->withMessage('Test error');
}),
]),
]);
try {
(new WorkflowWalker())->walk($workflow, [$rule]);
} catch (UnexpectedValueException $e) {
$this->assertSame(
[
'root' => [
'step_id' => 'root',
'message' => 'Test error',
],
],
$e->getErrors()
);
return;
}
$this->fail(sprintf("Exception of class '%s' was not thrown.", UnexpectedValueException::class));
}
public function testItCollectsUnrecognizedErrorsWithAGenericMessage(): void {
$workflow = $this->getWorkflow();
$workflow->setStatus(Workflow::STATUS_ACTIVE);
$rule = new ValidStepRule([
$this->makeEmpty(WorkflowNodeVisitor::class, [
'visitNode' => Expected::once(function () {
throw new Exception(' Unknown test error');
}),
]),
]);
try {
(new WorkflowWalker())->walk($workflow, [$rule]);
} catch (UnexpectedValueException $e) {
$this->assertSame(
[
'root' => [
'step_id' => 'root',
'message' => 'Unknown error.',
],
],
$e->getErrors()
);
return;
}
$this->fail(sprintf("Exception of class '%s' was not thrown.", UnexpectedValueException::class));
}
public function testItValidatesOnlyActiveWorkflows(): void {
$workflow = $this->getWorkflow();
$workflow->setStatus(Workflow::STATUS_DRAFT);
$rule = new ValidStepRule([
$this->makeEmpty(WorkflowNodeVisitor::class, [
'initialize' => Expected::never(),
'visitNode' => Expected::never(),
'complete' => Expected::never(),
])
]);
(new WorkflowWalker())->walk($workflow, [$rule]);
}
private function getWorkflow(): Workflow {
return $this->make(Workflow::class, [
'steps' => [
'root' => new Step('root', 'root', 'core:root', [], []),
],
]);
}
}