Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

handle empty/unchecked/checked checkboxes properly in both react and forms

Browse Source
This commit is contained in:
Jonathan Labreuille
2016-07-01 14:14:01 +02:00
parent 9de3a245b0
commit a8ffbc2d0e
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
assets/js/src/form/fields/checkbox.jsx
View File

@@ -6,7 +6,7 @@ function(
) {
const FormFieldCheckbox = React.createClass({
onValueChange: function(e) {
e.target.value = this.refs.checkbox.checked ? '1' : '';
e.target.value = this.refs.checkbox.checked ? '1' : '0';
return this.props.onValueChange(e);
},
render: function() {
@@ -14,7 +14,9 @@ function(
return false;
}
const isChecked = !!(this.props.item[this.props.field.name]);
// isChecked will be true only if the value is "1"
// it will be false in case value is "0" or empty
const isChecked = !!(~~(this.props.item[this.props.field.name]));
const options = Object.keys(this.props.field.values).map(
(value, index) => {
return (