Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove Subscribers IdiORM Model

Browse Source 
[MAILPOET-3820]
This commit is contained in:
Brezo Cordero
2021-11-22 13:29:20 -06:00
committed by Veljko V
parent 6f5cde2fbf
commit a901b1caa7
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/integration/Subscribers/InactiveSubscribersControllerTest.php
View File

@@ -10,7 +10,6 @@ use MailPoet\Entities\SendingQueueEntity;
use MailPoet\Entities\SettingEntity; use MailPoet\Entities\SettingEntity;
use MailPoet\Entities\StatisticsOpenEntity; use MailPoet\Entities\StatisticsOpenEntity;
use MailPoet\Entities\SubscriberEntity; use MailPoet\Entities\SubscriberEntity;
use MailPoet\Models\Subscriber;
use MailPoet\Settings\SettingsRepository; use MailPoet\Settings\SettingsRepository;
use MailPoet\Tasks\Sending; use MailPoet\Tasks\Sending;
use MailPoetVendor\Carbon\Carbon; use MailPoetVendor\Carbon\Carbon;
@@ -211,8 +210,8 @@ class InactiveSubscribersControllerTest extends \MailPoetTest {
$subscriber2 = $this->subscribersRepository->findOneById($subscriber2->getId()); $subscriber2 = $this->subscribersRepository->findOneById($subscriber2->getId());
assert($subscriber1 instanceof SubscriberEntity); assert($subscriber1 instanceof SubscriberEntity);
assert($subscriber2 instanceof SubscriberEntity); assert($subscriber2 instanceof SubscriberEntity);
expect($subscriber1->getStatus() === Subscriber::STATUS_INACTIVE || $subscriber2->getStatus() === Subscriber::STATUS_INACTIVE)->true(); expect($subscriber1->getStatus() === SubscriberEntity::STATUS_INACTIVE || $subscriber2->getStatus() === SubscriberEntity::STATUS_INACTIVE)->true();
expect($subscriber1->getStatus() === Subscriber::STATUS_SUBSCRIBED || $subscriber2->getStatus() === Subscriber::STATUS_SUBSCRIBED)->true(); expect($subscriber1->getStatus() === SubscriberEntity::STATUS_SUBSCRIBED || $subscriber2->getStatus() === SubscriberEntity::STATUS_SUBSCRIBED)->true();
$result = $this->controller->markActiveSubscribers(self::INACTIVITY_DAYS_THRESHOLD, $batchSize); $result = $this->controller->markActiveSubscribers(self::INACTIVITY_DAYS_THRESHOLD, $batchSize);
$this->entityManager->clear(); $this->entityManager->clear();
@@ -221,8 +220,8 @@ class InactiveSubscribersControllerTest extends \MailPoetTest {
$subscriber2 = $this->subscribersRepository->findOneById($subscriber2->getId()); $subscriber2 = $this->subscribersRepository->findOneById($subscriber2->getId());
assert($subscriber1 instanceof SubscriberEntity); assert($subscriber1 instanceof SubscriberEntity);
assert($subscriber2 instanceof SubscriberEntity); assert($subscriber2 instanceof SubscriberEntity);
expect($subscriber1->getStatus())->equals(Subscriber::STATUS_SUBSCRIBED); expect($subscriber1->getStatus())->equals(SubscriberEntity::STATUS_SUBSCRIBED);
expect($subscriber2->getStatus())->equals(Subscriber::STATUS_SUBSCRIBED); expect($subscriber2->getStatus())->equals(SubscriberEntity::STATUS_SUBSCRIBED);
} }
public function testItDoesNotActivateOldSubscribersWithUnopenedEmail(): void { public function testItDoesNotActivateOldSubscribersWithUnopenedEmail(): void {
@@ -268,7 +267,7 @@ class InactiveSubscribersControllerTest extends \MailPoetTest {
private function createSubscriber( private function createSubscriber(
string $email, string $email,
int $createdDaysAgo = 0, int $createdDaysAgo = 0,
string $status = Subscriber::STATUS_SUBSCRIBED string $status = SubscriberEntity::STATUS_SUBSCRIBED
): SubscriberEntity { ): SubscriberEntity {
$createdAt = (new Carbon())->subDays($createdDaysAgo); $createdAt = (new Carbon())->subDays($createdDaysAgo);
$subscriber = new SubscriberEntity(); $subscriber = new SubscriberEntity();