Check properly if value is found

[MAILPOET-2535]
This commit is contained in:
Pavel Dohnal
2019-11-19 13:24:26 +01:00
committed by Jack Kitterhing
parent 99ca99cae8
commit aa050c211b

View File

@@ -44,11 +44,12 @@ class Sending {
]; ];
private function __construct(ScheduledTask $task = null, SendingQueue $queue = null) { private function __construct(ScheduledTask $task = null, SendingQueue $queue = null) {
if (is_null($task) && is_null($queue)) { if (!$task instanceof ScheduledTask) {
$task = ScheduledTask::create(); $task = ScheduledTask::create();
$task->type = self::TASK_TYPE; $task->type = self::TASK_TYPE;
$task->save(); $task->save();
}
if (!$queue instanceof SendingQueue) {
$queue = SendingQueue::create(); $queue = SendingQueue::create();
$queue->newsletter_id = 0; $queue->newsletter_id = 0;
$queue->task_id = $task->id; $queue->task_id = $task->id;
@@ -105,7 +106,7 @@ class Sending {
$queue = SendingQueue::where('newsletter_id', $newsletter_id) $queue = SendingQueue::where('newsletter_id', $newsletter_id)
->orderByDesc('updated_at') ->orderByDesc('updated_at')
->findOne(); ->findOne();
if (!$queue) { if (!$queue instanceof SendingQueue) {
return false; return false;
} }