From aa105effc7e3dd77007c034bce806610beab6f6f Mon Sep 17 00:00:00 2001 From: Rostislav Wolny Date: Fri, 10 May 2019 10:20:01 +0200 Subject: [PATCH] Fix silent errors in confirmation mailer [MAILPOET-1987] --- lib/Subscribers/ConfirmationEmailMailer.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/Subscribers/ConfirmationEmailMailer.php b/lib/Subscribers/ConfirmationEmailMailer.php index d960c230b3..4186d86545 100644 --- a/lib/Subscribers/ConfirmationEmailMailer.php +++ b/lib/Subscribers/ConfirmationEmailMailer.php @@ -4,6 +4,7 @@ namespace MailPoet\Subscribers; use Html2Text\Html2Text; use MailPoet\Mailer\Mailer; +use MailPoet\Mailer\MailerError; use MailPoet\Models\Subscriber; use MailPoet\Settings\SettingsController; use MailPoet\Subscription\Url; @@ -106,7 +107,12 @@ class ConfirmationEmailMailer { } $this->mailer->getSenderNameAndAddress($from); $this->mailer->getReplyToNameAndAddress($reply_to); - return $this->mailer->send($email, $subscriber); + $result = $this->mailer->send($email, $subscriber); + if ($result['response'] === false) { + $subscriber->setError($result['error'] instanceof MailerError ? $result['error']->getMessage() : 'Unknown Error.'); + return false; + }; + return true; } catch (\Exception $e) { $subscriber->setError($e->getMessage()); return false;