Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove subscriber check from newsletter validator

Browse Source 
Checking the subscriber limit has nothing to do with the newsletter
itself, so it makes more sense to continue to perform that check as
needed elsewhere in the codebase.

MAILPOET-4236
This commit is contained in:
John Oleksowicz
2022-05-05 14:06:54 -05:00
committed by Veljko V
parent 73c023449b
commit ab609c8867
4 changed files with 14 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
mailpoet/tests/integration/API/JSON/v1/NewslettersTest.php
View File

@@ -22,7 +22,6 @@ use MailPoet\Entities\SubscriberSegmentEntity;
use MailPoet\Models\ScheduledTask;
use MailPoet\Models\SendingQueue;
use MailPoet\Newsletter\NewslettersRepository;
use MailPoet\Newsletter\NewsletterValidator;
use MailPoet\Newsletter\Options\NewsletterOptionFieldsRepository;
use MailPoet\Newsletter\Options\NewsletterOptionsRepository;
use MailPoet\Newsletter\Preview\SendPreviewController;
@@ -228,9 +227,7 @@ class NewslettersTest extends \MailPoetTest {
public function testItReturnsErrorIfSubscribersLimitReached() {
$endpoint = $this->createNewslettersEndpointWithMocks([
'cronHelper' => $this->cronHelper,
'newsletterValidator' => $this->getServiceWithOverrides(NewsletterValidator::class, [
'subscribersFeature' => Stub::make(Subscribers::class, ['check' => true])
])
'subscribersFeature' => Stub::make(Subscribers::class, ['check' => true])
]);
$res = $endpoint->setStatus([
'id' => $this->newsletter->getId(),