Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Avoid unnecesary loads

Browse Source 
[MAILPOET-3476]
This commit is contained in:
Pavel Dohnal
2021-03-29 13:23:42 +02:00
committed by Veljko V
parent f85850a19e
commit ae1a80ea25
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
assets/js/src/segments/dynamic/dynamic_segments_filters/email.tsx
View File

@@ -31,12 +31,12 @@ export function validateEmail(formItems: EmailFormItem): boolean {
return ((formItems.action in EmailActionTypes) && !!formItems.newsletter_id); return ((formItems.action in EmailActionTypes) && !!formItems.newsletter_id);
} }
const shouldDisplayLinks = (item: EmailFormItem): boolean => ( const shouldDisplayLinks = (itemAction: string, itemNewsletterId?: string): boolean => (
( (
(item.action === EmailActionTypes.CLICKED) (itemAction === EmailActionTypes.CLICKED)
|| (item.action === EmailActionTypes.NOT_CLICKED) || (itemAction === EmailActionTypes.NOT_CLICKED)
) )
&& (item.newsletter_id != null) && (itemNewsletterId != null)
); );
const newsletterOptions = SegmentFormData.newslettersList?.map((newsletter) => { const newsletterOptions = SegmentFormData.newslettersList?.map((newsletter) => {
@@ -78,14 +78,14 @@ export const EmailFields: React.FunctionComponent<Props> = ({ onChange, item })
} }
const loadLinksCB = useCallback(() => { const loadLinksCB = useCallback(() => {
if (!shouldDisplayLinks(item)) return; if (!shouldDisplayLinks(item.action, item.newsletter_id)) return;
setLinks([]); setLinks([]);
loadLinks(item.newsletter_id); loadLinks(item.newsletter_id);
}, [item]); }, [item.action, item.newsletter_id]);
useEffect(() => { useEffect(() => {
loadLinksCB(); loadLinksCB();
}, [loadLinksCB, item]); }, [loadLinksCB, item.action, item.newsletter_id]);
return ( return (
<> <>
@@ -107,7 +107,7 @@ export const EmailFields: React.FunctionComponent<Props> = ({ onChange, item })
</div> </div>
</div> </div>
{ {
(!!links.length && shouldDisplayLinks(item)) (!!links.length && shouldDisplayLinks(item.action, item.newsletter_id))
&& ( && (
<div className="mailpoet-form-field"> <div className="mailpoet-form-field">
<div className="mailpoet-form-input mailpoet-form-select"> <div className="mailpoet-form-input mailpoet-form-select">