From aed63c7cd32577c3e8568adf6a47155a3cc484ac Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Lys=C3=BD?= <jan.lysy@automattic.com>
Date: Mon, 17 Jun 2024 19:15:24 +0200
Subject: [PATCH] Create file with helper functions

To avoid code repetition I created a file,
which contains function that can be reused.
[MAILPOET-6097]
---
 .../scripts/check_woocommerce_versions.php    | 50 ++-----------------
 .../scripts/check_wordpress_versions.php      | 21 +-------
 .github/workflows/scripts/helpers.php         | 47 +++++++++++++++++
 3 files changed, 52 insertions(+), 66 deletions(-)
 create mode 100644 .github/workflows/scripts/helpers.php

diff --git a/.github/workflows/scripts/check_woocommerce_versions.php b/.github/workflows/scripts/check_woocommerce_versions.php
index 81e23a4464..3e5e7f85cc 100644
--- a/.github/workflows/scripts/check_woocommerce_versions.php
+++ b/.github/workflows/scripts/check_woocommerce_versions.php
@@ -1,5 +1,7 @@
 <?php
 
+require_once __DIR__ . '/helpers.php';
+
 function getWooCommerceVersions() {
   $url = "https://api.wordpress.org/plugins/info/1.0/woocommerce.json";
   $response = file_get_contents($url);
@@ -12,52 +14,6 @@ function getWooCommerceVersions() {
   return array_keys($data['versions']);
 }
 
-function filterStableVersions($versions) {
-  return array_filter($versions, function($version) {
-    // Only include stable versions (exclude versions with -rc, -beta, -alpha, etc.)
-    return !preg_match('/-(rc|beta|alpha|dev|nightly|pl)/i', $version);
-  });
-}
-
-function getLatestAndPreviousMinorMajorVersions($versions) {
-  usort($versions, 'version_compare');
-  $currentVersion = end($versions);
-
-  $previousVersion = null;
-  foreach (array_reverse($versions) as $version) {
-    if (version_compare($version, $currentVersion, '<') && getMinorMajorVersion($version) !== getMinorMajorVersion($currentVersion)) {
-      $previousVersion = $version;
-      break;
-    }
-  }
-
-  return [$currentVersion, $previousVersion];
-}
-
-function getMinorMajorVersion($version) {
-  $parts = explode('.', $version);
-  return $parts[0] . '.' . $parts[1];
-}
-
-function replaceVersionInFile($filePath, $pattern, $replacement): void {
-  $content = file_get_contents($filePath);
-
-  if ($content === false) {
-    die("Failed to read the file at $filePath.");
-  }
-
-  $updatedContent = preg_replace($pattern, $replacement, $content);
-
-  if ($updatedContent === null || $updatedContent === $content) {
-    echo "Nothing to update in $filePath\n";
-    return;
-  }
-
-  if (file_put_contents($filePath, $updatedContent) === false) {
-    die("Failed to write the updated file at $filePath.");
-  }
-}
-
 function replacePreviousVersion($previousVersion) {
   replaceVersionInFile(
     __DIR__ . './../../../.circleci/config.yml',
@@ -68,7 +24,7 @@ function replacePreviousVersion($previousVersion) {
 
 $allVersions = getWooCommerceVersions();
 $stableVersions = filterStableVersions($allVersions);
-list($latestVersion, $previousVersion) = getLatestAndPreviousMinorMajorVersions($stableVersions);
+[$latestVersion, $previousVersion] = getLatestAndPreviousMinorMajorVersions($stableVersions);
 
 
 echo "Latest WooCommerce version: $latestVersion\n";
diff --git a/.github/workflows/scripts/check_wordpress_versions.php b/.github/workflows/scripts/check_wordpress_versions.php
index f333cbbd29..3626d4399d 100644
--- a/.github/workflows/scripts/check_wordpress_versions.php
+++ b/.github/workflows/scripts/check_wordpress_versions.php
@@ -1,5 +1,7 @@
 <?php
 
+require_once __DIR__ . '/helpers.php';
+
 function fetchData($url): array {
   $response = file_get_contents($url);
   return json_decode($response, true);
@@ -44,25 +46,6 @@ function getLatestAndPreviousVersions($sortedVersions) {
   return [reset($latestVersionGroup), end($previousVersionGroup)];
 }
 
-function replaceVersionInFile($filePath, $pattern, $replacement) {
-  $content = file_get_contents($filePath);
-
-  if ($content === false) {
-    die("Failed to read the file at $filePath.");
-  }
-
-  $updatedContent = preg_replace($pattern, $replacement, $content);
-
-  if ($updatedContent === null || $updatedContent === $content) {
-    echo "Nothing to update in $filePath\n";
-    return;
-  }
-
-  if (file_put_contents($filePath, $updatedContent) === false) {
-    die("Failed to write the updated file at $filePath.");
-  }
-}
-
 function replaceLatestVersion($latestVersion) {
   replaceVersionInFile(
     __DIR__ . './../../../mailpoet/tests/docker/docker-compose.yml',
diff --git a/.github/workflows/scripts/helpers.php b/.github/workflows/scripts/helpers.php
new file mode 100644
index 0000000000..870056c96c
--- /dev/null
+++ b/.github/workflows/scripts/helpers.php
@@ -0,0 +1,47 @@
+<?php
+
+function replaceVersionInFile($filePath, $pattern, $replacement) {
+  $content = file_get_contents($filePath);
+
+  if ($content === false) {
+    die("Failed to read the file at $filePath.");
+  }
+
+  $updatedContent = preg_replace($pattern, $replacement, $content);
+
+  if ($updatedContent === null || $updatedContent === $content) {
+    echo "Nothing to update in $filePath\n";
+    return;
+  }
+
+  if (file_put_contents($filePath, $updatedContent) === false) {
+    die("Failed to write the updated file at $filePath.");
+  }
+}
+
+function filterStableVersions($versions) {
+  return array_filter($versions, function($version) {
+    // Only include stable versions (exclude versions with -rc, -beta, -alpha, etc.)
+    return preg_match('/^\d+\.\d+\.\d+$/', $version);
+  });
+}
+
+function getLatestAndPreviousMinorMajorVersions($versions) {
+  usort($versions, 'version_compare');
+  $currentVersion = end($versions);
+
+  $previousVersion = null;
+  foreach (array_reverse($versions) as $version) {
+    if (version_compare($version, $currentVersion, '<') && getMinorMajorVersion($version) !== getMinorMajorVersion($currentVersion)) {
+      $previousVersion = $version;
+      break;
+    }
+  }
+
+  return [$currentVersion, $previousVersion];
+}
+
+function getMinorMajorVersion($version) {
+  $parts = explode('.', $version);
+  return $parts[0] . '.' . $parts[1];
+}