Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove unnecessary check

Browse Source 
[MAILPOET-3737]
This commit is contained in:
Pavel Dohnal
2021-09-01 14:00:08 +02:00
committed by Veljko V
parent d1b2458227
commit b0b6f1ff35
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Segments/DynamicSegments/Filters/EmailAction.php
View File

@@ -103,7 +103,7 @@ class EmailAction implements Filter {
)->setParameter('newsletter' . $parameterSuffix, $newsletterId); )->setParameter('newsletter' . $parameterSuffix, $newsletterId);
} }
if ($action === EmailAction::ACTION_OPENED) { if ($action === EmailAction::ACTION_OPENED) {
$queryBuilder->andWhere('(stats.user_agent_type = :userAgentType) OR (stats.user_agent_type IS NULL)') $queryBuilder->andWhere('stats.user_agent_type = :userAgentType')
->setParameter('userAgentType', UserAgentEntity::USER_AGENT_TYPE_HUMAN); ->setParameter('userAgentType', UserAgentEntity::USER_AGENT_TYPE_HUMAN);
} }
if ($action === EmailAction::ACTION_MACHINE_OPENED) { if ($action === EmailAction::ACTION_MACHINE_OPENED) {

4
lib/Segments/DynamicSegments/Filters/EmailOpensAbsoluteCountAction.php
View File

@@ -45,10 +45,10 @@ class EmailOpensAbsoluteCountAction implements Filter {
} }
$queryBuilder->setParameter('opens' . $parameterSuffix, $filterData->getParam('opens')); $queryBuilder->setParameter('opens' . $parameterSuffix, $filterData->getParam('opens'));
if ($action === EmailOpensAbsoluteCountAction::TYPE) { if ($action === EmailOpensAbsoluteCountAction::TYPE) {
$queryBuilder->andWhere('(opens.user_agent_type = :userAgentType) OR (opens.user_agent_type IS NULL)') $queryBuilder->andWhere('opens.user_agent_type = :userAgentType')
->setParameter('userAgentType', UserAgentEntity::USER_AGENT_TYPE_HUMAN); ->setParameter('userAgentType', UserAgentEntity::USER_AGENT_TYPE_HUMAN);
} else { } else {
$queryBuilder->andWhere('(opens.user_agent_type = :userAgentType)') $queryBuilder->andWhere('opens.user_agent_type = :userAgentType')
->setParameter('userAgentType', UserAgentEntity::USER_AGENT_TYPE_MACHINE); ->setParameter('userAgentType', UserAgentEntity::USER_AGENT_TYPE_MACHINE);
} }
return $queryBuilder; return $queryBuilder;