From b16071ee0e2d5f1cd5185acc3d2583c859b636e7 Mon Sep 17 00:00:00 2001
From: Oluwaseun Olorunsola <seun.olorunsola@automattic.com>
Date: Wed, 5 Feb 2025 08:40:39 +0100
Subject: [PATCH] Remove unnecessary use of updateEmailMailPoetProperty

MAILPOET-6431
---
 .../email-sidebar-extension.tsx               |  8 +------
 .../src/components/header/more-menu.tsx       |  7 +-----
 packages/js/email-editor/src/store/actions.ts | 23 -------------------
 3 files changed, 2 insertions(+), 36 deletions(-)

diff --git a/mailpoet/assets/js/src/mailpoet-email-editor-integration/email-sidebar-extension.tsx b/mailpoet/assets/js/src/mailpoet-email-editor-integration/email-sidebar-extension.tsx
index 9da9f4e64f..e99b7b7eec 100644
--- a/mailpoet/assets/js/src/mailpoet-email-editor-integration/email-sidebar-extension.tsx
+++ b/mailpoet/assets/js/src/mailpoet-email-editor-integration/email-sidebar-extension.tsx
@@ -53,7 +53,6 @@ export function EmailSidebarExtensionBody({ RichTextWithButton }) {
           href="https://www.mailpoet.com/blog/17-email-subject-line-best-practices-to-boost-engagement/"
           target="_blank"
           rel="noopener noreferrer"
-          onClick={() => {}}
         />
       ),
       emojiLink: (
@@ -62,7 +61,6 @@ export function EmailSidebarExtensionBody({ RichTextWithButton }) {
           href="https://www.mailpoet.com/blog/tips-using-emojis-in-subject-lines/"
           target="_blank"
           rel="noopener noreferrer"
-          onClick={() => {}}
         />
       ),
     },
@@ -86,7 +84,6 @@ export function EmailSidebarExtensionBody({ RichTextWithButton }) {
           key="preview-text-kb"
           target="_blank"
           rel="noopener noreferrer"
-          onClick={() => {}}
         />
       ),
     },
@@ -100,10 +97,7 @@ export function EmailSidebarExtensionBody({ RichTextWithButton }) {
         updateProperty={updateEmailMailPoetProperty}
         label={__('Subject', 'mailpoet')}
         labelSuffix={
-          <ExternalLink
-            href="https://kb.mailpoet.com/article/435-a-guide-to-personalisation-tags-for-tailored-newsletters#list"
-            onClick={() => {}}
-          >
+          <ExternalLink href="https://kb.mailpoet.com/article/435-a-guide-to-personalisation-tags-for-tailored-newsletters#list">
             {__('Guide', 'mailpoet')}
           </ExternalLink>
         }
diff --git a/packages/js/email-editor/src/components/header/more-menu.tsx b/packages/js/email-editor/src/components/header/more-menu.tsx
index 5ae46fa073..07a30639dd 100644
--- a/packages/js/email-editor/src/components/header/more-menu.tsx
+++ b/packages/js/email-editor/src/components/header/more-menu.tsx
@@ -35,8 +35,7 @@ export function MoreMenu(): JSX.Element {
 		editorCurrentPostType,
 		'status'
 	);
-	const { saveEditedEmail, updateEmailMailPoetProperty } =
-		useDispatch( storeName );
+	const { saveEditedEmail } = useDispatch( storeName );
 	const goToListings = () => {
 		window.location.href = urls.listings;
 	};
@@ -132,10 +131,6 @@ export function MoreMenu(): JSX.Element {
 								<MenuItem
 									onClick={ async () => {
 										await setStatus( 'draft' );
-										await updateEmailMailPoetProperty(
-											'deleted_at',
-											''
-										);
 										await saveEditedEmail();
 										recordEvent(
 											'header_more_menu_restore_from_trash_button_clicked'
diff --git a/packages/js/email-editor/src/store/actions.ts b/packages/js/email-editor/src/store/actions.ts
index e099cc0da3..035102e665 100644
--- a/packages/js/email-editor/src/store/actions.ts
+++ b/packages/js/email-editor/src/store/actions.ts
@@ -134,29 +134,6 @@ export function* saveEditedEmail() {
 	} );
 }
 
-export function* updateEmailMailPoetProperty( name: string, value: string ) {
-	const postId = select( storeName ).getEmailPostId();
-	// There can be a better way how to get the edited post data
-	const editedPost = select( coreDataStore ).getEditedEntityRecord(
-		'postType',
-		editorCurrentPostType,
-		postId
-	);
-	// @ts-expect-error Property 'mailpoet_data' does not exist on type 'Updatable<Attachment<any>>'.
-	const mailpoetData = editedPost?.mailpoet_data || {};
-	yield dispatch( coreDataStore ).editEntityRecord(
-		'postType',
-		editorCurrentPostType,
-		postId,
-		{
-			mailpoet_data: {
-				...mailpoetData,
-				[ name ]: value,
-			},
-		}
-	);
-}
-
 export const setTemplateToPost =
 	( templateSlug ) =>
 	async ( { registry } ) => {