Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Fix tests that were not testing what they should

Browse Source 
[MAILPOET-2017]
This commit is contained in:
Jan Jakeš
2019-05-01 09:19:32 +02:00
committed by M. Shull
parent 9458a0c0ea
commit b3751ca775
1 changed files with 26 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
tests/integration/Cron/DaemonHttpRunnerTest.php
View File

@@ -109,50 +109,57 @@ class DaemonHttpRunnerTest extends \MailPoetTest {
function testItTerminatesExecutionWhenDaemonIsDeleted() { function testItTerminatesExecutionWhenDaemonIsDeleted() {
$workers_factory_mock = $this->createWorkersFactoryMock([
'createScheduleWorker' => Stub::makeEmpty(SimpleWorker::class, [
'process' => function () {
$this->settings->delete(CronHelper::DAEMON_SETTING);
}
]),
]);
$daemon = Stub::make(DaemonHttpRunner::class, array( $daemon = Stub::make(DaemonHttpRunner::class, array(
'executeScheduleWorker' => function() {
$this->settings->delete(CronHelper::DAEMON_SETTING);
},
'executeQueueWorker' => null,
'pauseExecution' => null, 'pauseExecution' => null,
'terminateRequest' => Expected::exactly(1) 'terminateRequest' => Expected::exactly(1),
'callSelf' => Expected::never(),
), $this); ), $this);
$data = array( $data = array(
'token' => 123 'token' => 123
); );
$this->settings->set(CronHelper::DAEMON_SETTING, $data); $this->settings->set(CronHelper::DAEMON_SETTING, $data);
$daemon->__construct(Stub::makeEmpty(Daemon::class)); $daemon->__construct(new Daemon($this->settings, $workers_factory_mock));
$daemon->run($data); $daemon->run($data);
} }
function testItTerminatesExecutionWhenDaemonTokenChangesAndKeepsChangedToken() { function testItTerminatesExecutionWhenDaemonTokenChangesAndKeepsChangedToken() {
$workers_factory_mock = $this->createWorkersFactoryMock([
'createScheduleWorker' => Stub::makeEmpty(SimpleWorker::class, [
'process' => function () {
$this->settings->set(
CronHelper::DAEMON_SETTING,
array('token' => 567)
);
}
]),
]);
$daemon = Stub::make(DaemonHttpRunner::class, array( $daemon = Stub::make(DaemonHttpRunner::class, array(
'executeScheduleWorker' => function() {
$this->settings->set(
CronHelper::DAEMON_SETTING,
array('token' => 567)
);
},
'executeQueueWorker' => null,
'pauseExecution' => null, 'pauseExecution' => null,
'terminateRequest' => Expected::exactly(1) 'terminateRequest' => Expected::exactly(1),
'callSelf' => Expected::never(),
), $this); ), $this);
$data = array( $data = array(
'token' => 123 'token' => 123
); );
$this->settings->set(CronHelper::DAEMON_SETTING, $data); $this->settings->set(CronHelper::DAEMON_SETTING, $data);
$daemon->__construct(Stub::makeEmpty(Daemon::class)); $daemon->__construct(new Daemon($this->settings, $workers_factory_mock));
$daemon->run($data); $daemon->run($data);
$data_after_run = $this->settings->get(CronHelper::DAEMON_SETTING); $data_after_run = $this->settings->get(CronHelper::DAEMON_SETTING);
expect($data_after_run['token'], 567); expect($data_after_run['token'])->equals(567);
} }
function testItTerminatesExecutionWhenDaemonIsDeactivated() { function testItTerminatesExecutionWhenDaemonIsDeactivated() {
$daemon = Stub::make(DaemonHttpRunner::class, [ $daemon = Stub::make(DaemonHttpRunner::class, [
'executeScheduleWorker' => null,
'executeQueueWorker' => null,
'pauseExecution' => null, 'pauseExecution' => null,
'terminateRequest' => Expected::exactly(1) 'terminateRequest' => Expected::exactly(1),
'callSelf' => Expected::never(),
], $this); ], $this);
$data = [ $data = [
'token' => 123, 'token' => 123,