Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Rename removeSubscribers() method and encapsulate task completion logic [MAILPOET-987]

Browse Source
This commit is contained in:
stoletniy
2017-07-20 11:22:47 +03:00
parent c924778d50
commit b42d8e68d9
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/Tasks/Subscribers.php
View File

@@ -24,7 +24,7 @@ class Subscribers {
return !empty($subscriber);
}
function removeNonexistentSubscribers($subscribers_to_remove) {
function removeSubscribers($subscribers_to_remove) {
$this->getSubscribers()
->whereIn('subscriber_id', $subscribers_to_remove)
->deleteMany();
@@ -42,8 +42,7 @@ class Subscribers {
private function checkCompleted() {
if(!ScheduledTaskSubscriber::getUnprocessedCount($this->task->id)) {
$this->task->processed_at = current_time('mysql');
return $this->task->complete();
$this->task->complete();
}
}
}