Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Remove MailPoet premium version from individual calls to trackEvent()

Browse Source 
This commit removes the property 'MailPoet Premium version' from all the
calls to MailPoet.trackEvent(). It is not necessary to pass this
property anymore, as since 0a10300625,
this property is included automatically whenever MailPoet send data to
Mixpanel.

[MAILPOET-3885]
This commit is contained in:
Rodrigo Primo
2021-11-10 15:57:34 -03:00
committed by Veljko V
parent 39df0090ae
commit b4b1546a54
3 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
assets/js/src/newsletters/automatic_emails/events_conditions.jsx
View File

@@ -116,7 +116,6 @@ class EventsConditions extends React.Component {
}, },
}).done((response) => { }).done((response) => {
MailPoet.trackEvent('Emails > New Automatic Email Created', { MailPoet.trackEvent('Emails > New Automatic Email Created', {
'MailPoet Premium version': window.mailpoet_premium_version,
'Event type': options.event, 'Event type': options.event,
'Schedule type': options.afterTimeType, 'Schedule type': options.afterTimeType,
'Schedule value': options.afterTimeNumber, 'Schedule value': options.afterTimeNumber,

5
assets/js/src/newsletters/send/ga_tracking.jsx
View File

@@ -4,10 +4,7 @@ import MailPoet from 'mailpoet';
import ReactStringReplace from 'react-string-replace'; import ReactStringReplace from 'react-string-replace';
// Track once per page load // Track once per page load
const trackCampaignNameTyped = _.once(() => MailPoet.trackEvent( const trackCampaignNameTyped = _.once(() => MailPoet.trackEvent('User has typed a GA campaign name'));
'User has typed a GA campaign name',
{ 'MailPoet Premium version': window.mailpoet_premium_version }
));
const tipLink = 'https://kb.mailpoet.com/article/187-track-your-newsletters-subscribers-in-google-analytics'; const tipLink = 'https://kb.mailpoet.com/article/187-track-your-newsletters-subscribers-in-google-analytics';
const tip = ReactStringReplace( const tip = ReactStringReplace(
MailPoet.I18n.t('gaCampaignTip'), MailPoet.I18n.t('gaCampaignTip'),

1
assets/js/src/newsletters/types/automatic_emails/events_list.jsx
View File

@@ -15,7 +15,6 @@ class AutomaticEmailEventsList extends React.Component {
eventsConfigurator(eventSlug) { eventsConfigurator(eventSlug) {
MailPoet.trackEvent('Emails > Automatic Type selected', { MailPoet.trackEvent('Emails > Automatic Type selected', {
'MailPoet Premium version': window.mailpoet_premium_version,
'Email type': eventSlug, 'Email type': eventSlug,
}); });
this.props.history.push(`/new/${this.email.slug}/${eventSlug}/conditions`); this.props.history.push(`/new/${this.email.slug}/${eventSlug}/conditions`);