Makes code more readable/cleaner

This commit is contained in:
Vlad
2017-02-20 09:25:42 -05:00
parent bf4023c0ad
commit b74f40c7a8

View File

@ -5,36 +5,31 @@ class SubscriberCustomFieldTest extends MailPoetTest {
function __construct() { function __construct() {
$this->data = array( $this->data = array(
array( array(
10, 'custom_field_id' => 10,
// custom_field_id 'subscriber_id' => 12,
12, 'value' => 'Test 1'
// subscriber_id
'Test 1'
// value
), ),
array( array(
10, 'custom_field_id' => 10,
// custom_field_id 'subscriber_id' => 13,
13, 'value' => 'Test 2'
// subscriber_id
'Test 2'
// value
) )
); );
} }
function testItCanBeCreated() { function testItCanBeCreated() {
$subscriberCustomField = SubscriberCustomField::create(); $subscriberCustomField = SubscriberCustomField::create();
$subscriberCustomField->custom_field_id = $this->data[0][0]; $subscriberCustomField->custom_field_id = $this->data[0]['custom_field_id'];
$subscriberCustomField->subscriber_id = $this->data[0][1]; $subscriberCustomField->subscriber_id = $this->data[0]['subscriber_id'];
$subscriberCustomField->value = $this->data[0][2]; $subscriberCustomField->value = $this->data[0]['value'];
$subscriberCustomField->save(); $subscriberCustomField->save();
expect($subscriberCustomField->id())->greaterOrEquals(1); expect($subscriberCustomField->id())->greaterOrEquals(1);
expect($subscriberCustomField->getErrors())->false(); expect($subscriberCustomField->getErrors())->false();
} }
function testItCanCreateMultipleRecords() { function testItCanCreateMultipleRecords() {
SubscriberCustomField::createMultiple($this->data); $data = array_map('array_values', $this->data);
SubscriberCustomField::createMultiple($data);
$records = SubscriberCustomField::findArray(); $records = SubscriberCustomField::findArray();
expect(count($records))->equals(2); expect(count($records))->equals(2);
expect($records[0]['value'])->equals('Test 1'); expect($records[0]['value'])->equals('Test 1');
@ -42,9 +37,11 @@ class SubscriberCustomFieldTest extends MailPoetTest {
} }
function testItCanUpdateMultipleRecords() { function testItCanUpdateMultipleRecords() {
SubscriberCustomField::createMultiple($this->data); $data = array_map('array_values', $this->data);
SubscriberCustomField::createMultiple($data);
$updated_data = $this->data; $updated_data = $this->data;
$updated_data[0][2] = 'Updated'; $updated_data[0]['value'] = 'Updated';
$updated_data = array_map('array_values', $updated_data);
SubscriberCustomField::updateMultiple($updated_data); SubscriberCustomField::updateMultiple($updated_data);
$records = SubscriberCustomField::findArray(); $records = SubscriberCustomField::findArray();
expect($records[0]['value'])->equals('Updated'); expect($records[0]['value'])->equals('Updated');
@ -52,11 +49,12 @@ class SubscriberCustomFieldTest extends MailPoetTest {
} }
function testItCanDeleteManySubscriberRelations() { function testItCanDeleteManySubscriberRelations() {
SubscriberCustomField::createMultiple($this->data); $data = array_map('array_values', $this->data);
SubscriberCustomField::createMultiple($data);
SubscriberCustomField::deleteManySubscriberRelations( SubscriberCustomField::deleteManySubscriberRelations(
array( array(
$this->data[0][1], $this->data[0]['subscriber_id'],
$this->data[1][1] $this->data[1]['subscriber_id']
) )
); );
$records = SubscriberCustomField::findArray(); $records = SubscriberCustomField::findArray();
@ -64,8 +62,9 @@ class SubscriberCustomFieldTest extends MailPoetTest {
} }
function testItCanDeleteSubscriberRelations() { function testItCanDeleteSubscriberRelations() {
SubscriberCustomField::createMultiple($this->data); $data = array_map('array_values', $this->data);
$subscriber = (object)array('id' => $this->data[0][1]); SubscriberCustomField::createMultiple($data);
$subscriber = (object)array('id' => $this->data[0]['subscriber_id']);
SubscriberCustomField::deleteSubscriberRelations($subscriber); SubscriberCustomField::deleteSubscriberRelations($subscriber);
$records = SubscriberCustomField::findArray(); $records = SubscriberCustomField::findArray();
expect($records)->count(1); expect($records)->count(1);