Cavemanon/piratepoet
7
Fork 0
Code Pull Requests Actions Releases 16 Activity

Don't serialize meta fields if they're null [MAILPOET-2073]

Browse Source
This commit is contained in:
wxa
2019-05-14 12:24:57 +03:00
committed by M. Shull
parent e15fd4661e
commit b99096d2df
4 changed files with 29 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/integration/Models/SendingQueueTest.php
View File

@ -113,6 +113,20 @@ class SendingQueueTest extends \MailPoetTest {
expect(json_decode($queue->meta, true))->equals($meta);
}
function testItDoesNotJsonEncodesMetaEqualToNull() {
$queue = SendingQueue::create();
$meta = null;
$queue->task_id = 0;
$queue->newsletter_id = 1;
$queue->meta = $meta;
$queue->save();
$queue = SendingQueue::findOne($queue->id);
expect(Helpers::isJson($queue->meta))->false();
expect($queue->meta)->equals($meta);
}
function testItReencodesSerializedObjectToJsonEncoded() {
$queue = $this->queue;
$newsletter_rendered_body = $this->rendered_body;