Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Unit tests for Settings getValue/setValue

Browse Source 
- fixed typo in Shortcodes
- changed for -> foreach
This commit is contained in:
Jonathan Labreuille
2016-01-15 15:50:23 +01:00
parent 3689545589
commit bb77134224
3 changed files with 35 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
lib/Models/Setting.php
View File

@@ -51,7 +51,6 @@ class Setting extends Model {
$keys = explode('.', $key);
if(count($keys) === 1) {
if(is_array($value)) {
$value = serialize($value);
}
@@ -67,17 +66,15 @@ class Setting extends Model {
$current_value = &$setting_value;
$last_key = array_pop($keys);
for($i = 0, $count = count($keys); $i < $count; $i++) {
if($i < $count) {
if(!is_array($current_value)) {
$current_value = array();
}
if(!array_key_exists($keys[$i], $current_value)) {
$current_value = array($keys[$i] => array());
}
$current_value =& $current_value[$keys[$i]];
foreach($keys as $key) {
if(!is_array($current_value)) {
$current_value = array();
}
if(!array_key_exists($key, $current_value)) {
$current_value = array($key => array());
}
$current_value =& $current_value[$key];
}
if(is_scalar($current_value)) {
$current_value = array();