Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Rename flag for skipping tests in webpack build

Browse Source 
[MAILPOET-5714]
This commit is contained in:
Rostislav Wolny
2024-01-19 17:06:20 +01:00
committed by Aschepikov
parent ef99b96b66
commit bbc4a86759
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
mailpoet/RoboFile.php
View File

@@ -191,7 +191,7 @@ class RoboFile extends \Robo\Tasks {
$this->_exec('./node_modules/webpack/bin/webpack.js --watch'); $this->_exec('./node_modules/webpack/bin/webpack.js --watch');
} }
public function compileAll($opts = ['env' => null, 'tests' => 'build']) { public function compileAll($opts = ['env' => null, 'skip-tests' => false]) {
$collection = $this->collectionBuilder(); $collection = $this->collectionBuilder();
$collection->addCode(function() use ($opts) { $collection->addCode(function() use ($opts) {
return call_user_func([$this, 'compileJs'], $opts); return call_user_func([$this, 'compileJs'], $opts);
@@ -202,7 +202,7 @@ class RoboFile extends \Robo\Tasks {
return $collection->run(); return $collection->run();
} }
public function compileJs($opts = ['env' => null]) { public function compileJs($opts = ['env' => null, 'skip-tests' => false]) {
if (!is_dir('assets/dist/js')) { if (!is_dir('assets/dist/js')) {
mkdir('assets/dist/js', 0777, true); mkdir('assets/dist/js', 0777, true);
} }
@@ -210,7 +210,7 @@ class RoboFile extends \Robo\Tasks {
$env = ($opts['env']) ? $env = ($opts['env']) ?
sprintf('./node_modules/.bin/cross-env NODE_ENV="%s"', $opts['env']) : sprintf('./node_modules/.bin/cross-env NODE_ENV="%s"', $opts['env']) :
null; null;
return $this->_exec($env . ' ./node_modules/webpack/bin/webpack.js --env BUILD_TESTS=' . ($opts['tests'] === 'build' ? 'build' : 'skip')); return $this->_exec($env . ' ./node_modules/webpack/bin/webpack.js --env BUILD_TESTS=' . ($opts['skip-tests'] ? 'skip' : 'build'));
} }
public function compileCss($opts = ['env' => null]) { public function compileCss($opts = ['env' => null]) {

2
mailpoet/build.sh
View File

@@ -15,7 +15,7 @@ mkdir $plugin_name
echo '[BUILD] Generating production CSS and JS assets' echo '[BUILD] Generating production CSS and JS assets'
rm -rf node_modules rm -rf node_modules
pnpm install --frozen-lockfile --prefer-offline pnpm install --frozen-lockfile --prefer-offline
./do compile:all --env production --tests skip ./do compile:all --env production --skip-tests
# Extract translations. # Extract translations.
echo '[BUILD] Generating translations .pot file' echo '[BUILD] Generating translations .pot file'