Cavemanon/piratepoet
8
Fork 0
Code Pull Requests Actions Releases 16 Activity

Fix showing segment subscriber counts on newsletter creation pages

Browse Source
This commit is contained in:
Tautvidas Sipavičius
2016-10-04 11:54:07 +03:00
parent b0ab9e0408
commit bbd02260be
3 changed files with 3 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
assets/js/src/newsletters/send/notification.jsx
View File

@@ -40,11 +40,7 @@ define(
return !!(!segment.deleted_at); return !!(!segment.deleted_at);
}, },
getLabel: function(segment) { getLabel: function(segment) {
var name = segment.name; return segment.name + ' (' + parseInt(segment.subscribers).toLocaleString() + ')';
if (segment.subscribers > 0) {
name += ' (%$1s)'.replace('%$1s', parseInt(segment.subscribers).toLocaleString());
}
return name;
}, },
validation: { validation: {
'data-parsley-required': true, 'data-parsley-required': true,

6
assets/js/src/newsletters/send/standard.jsx
View File

@@ -346,11 +346,7 @@ define(
return !!(!segment.deleted_at); return !!(!segment.deleted_at);
}, },
getLabel: function(segment) { getLabel: function(segment) {
var name = segment.name; return segment.name + ' (' + parseInt(segment.subscribers).toLocaleString() + ')';
if (segment.subscribers > 0) {
name += ' (%$1s)'.replace('%$1s', parseInt(segment.subscribers).toLocaleString());
}
return name;
}, },
validation: { validation: {
'data-parsley-required': true, 'data-parsley-required': true,

5
assets/js/src/newsletters/types/welcome/scheduling.jsx
View File

@@ -27,10 +27,7 @@ const events = {
const availableSegmentValues = _.object(_.map( const availableSegmentValues = _.object(_.map(
availableSegments, availableSegments,
function(segment) { function(segment) {
let name = segment.name; let name = segment.name + ' (' + parseInt(segment.subscribers).toLocaleString() + ')';
if (segment.subscribers > 0) {
name += ' (%$1s)'.replace('%$1s', parseInt(segment.subscribers).toLocaleString());
}
return [segment.id, name]; return [segment.id, name];
} }
)); ));